commit e334aab65bfb3d6f43d6ecf929d166a38fae2007
author Daniel Rosenberg <drosen@google.com> Wed Oct 10 18:52:04 2018 -0700
committer Paul Lawrence <paullawrence@google.com> Tue Oct 16 08:31:14 2018 -0700
tree 99434d950c55c179c27a9c4d80e6041dc16ef62d
parent cf540f35138caf395334c605dc3e986d5e821f74

Switch to exceptions for most cp calls

This switches the checkpoint calls that don't need to return a value
to return 0 on success, and an error on failure. This will be transalted
to exceptions for java binder users. needsCheckpoint and needsRollback
still return a boolean value.

Test: vdc setCheckpoint 2 then reboot 3 times checking state
Bug: 112901762
Change-Id: Idd3b5e6036631562a86d5123f533b86cf3bd6032

VoldNativeService.h

diff --git a/VoldNativeService.h b/VoldNativeService.h
index 7f1d807..8a3ac00 100644
--- a/VoldNativeService.h
+++ b/VoldNativeService.h
@@ -121,13 +121,13 @@
     binder::Status destroySandboxForApp(const std::string& packageName, int32_t appId,
                                         const std::string& sandboxId, int32_t userId);
 
-    binder::Status startCheckpoint(int32_t retry, bool* _aidl_return);
+    binder::Status startCheckpoint(int32_t retry);
     binder::Status needsCheckpoint(bool* _aidl_return);
     binder::Status needsRollback(bool* _aidl_return);
-    binder::Status commitChanges(bool* _aidl_return);
-    binder::Status prepareCheckpoint(bool* _aidl_return);
-    binder::Status restoreCheckpoint(const std::string& mountPoint, bool* _aidl_return);
-    binder::Status markBootAttempt(bool* __aidl_return);
+    binder::Status commitChanges();
+    binder::Status prepareCheckpoint();
+    binder::Status restoreCheckpoint(const std::string& mountPoint);
+    binder::Status markBootAttempt();
     binder::Status abortChanges();
 };