commit be857bfd9b96f8069d1a2a5447ab8ae922722716
author Paul Crowley <paulcrowley@google.com> Fri Dec 07 12:23:25 2018 -0800
committer Paul Crowley <paulcrowley@google.com> Fri Dec 07 12:23:25 2018 -0800
tree c3ea4eddbdd3aec67a3c51ebda0e9ab2c5498639
parent b46a2f7dea74c3968cac2adb4ab1e06309241535

Check for errors in dup2

Bug: 26735063
Test: adb shell sm partition disk:7,3 private && adb logcat -d
Change-Id: I3aa8d1f6183dd5e77f54f422482a54ea8197d768

Utils.cpp

diff --git a/Utils.cpp b/Utils.cpp
index 3bbdf3a..a77b1b6 100644
--- a/Utils.cpp
+++ b/Utils.cpp
@@ -312,7 +312,10 @@
             }
         }
         pipe_read.reset();
-        dup2(pipe_write.get(), STDOUT_FILENO);
+        if (dup2(pipe_write.get(), STDOUT_FILENO) == -1) {
+            PLOG(ERROR) << "dup2 in ForkExecvp";
+            _exit(EXIT_FAILURE);
+        }
         pipe_write.reset();
         execvp(argv[0], const_cast<char**>(argv.data()));
         PLOG(ERROR) << "exec in ForkExecvp";