commit a051eb7a22b7cd97e66d2f22b64884f8ebc73952
author Paul Crowley <paulcrowley@google.com> Tue Mar 08 16:08:32 2016 -0800
committer Paul Crowley <paulcrowley@google.com> Wed Mar 09 09:32:02 2016 -0800
tree c1a7230be3f042d281412c392754cbab63a3bd47
parent 320e5e15b621da57a947adc896f7bb8357038bee

Use pointers not references for out arguments

Google/Android C++ style requires that arguments passed in for writing
should be pointers, not references, so that it's visible in the caller
that they'll be written to.

Bug: 27566014
Change-Id: I5cd55906cc4b2f61c8b97b223786be0b3ce28862

Keymaster.h

diff --git a/Keymaster.h b/Keymaster.h
index a4deddf..dd20ef9 100644
--- a/Keymaster.h
+++ b/Keymaster.h
@@ -45,11 +45,11 @@
     explicit operator bool() {return mDevice != nullptr;}
     // Call "update" repeatedly until all of the input is consumed, and
     // concatenate the output. Return true on success.
-    bool updateCompletely(const std::string &input, std::string &output);
+    bool updateCompletely(const std::string &input, std::string *output);
     // Finish; pass nullptr for the "output" param.
     bool finish();
     // Finish and write the output to this string.
-    bool finishWithOutput(std::string &output);
+    bool finishWithOutput(std::string *output);
     // Move constructor
     KeymasterOperation(KeymasterOperation&& rhs) {
         mOpHandle = rhs.mOpHandle;
@@ -74,7 +74,7 @@
     // false if we failed to open the keymaster device.
     explicit operator bool() {return mDevice != nullptr;}
     // Generate a key in the keymaster from the given params.
-    bool generateKey(const AuthorizationSet &inParams, std::string &key);
+    bool generateKey(const AuthorizationSet &inParams, std::string *key);
     // If the keymaster supports it, permanently delete a key.
     bool deleteKey(const std::string &key);
     // Begin a new cryptographic operation, collecting output parameters.
@@ -82,7 +82,7 @@
             keymaster_purpose_t purpose,
             const std::string &key,
             const AuthorizationSet &inParams,
-            AuthorizationSet &outParams);
+            AuthorizationSet *outParams);
     // Begin a new cryptographic operation; don't collect output parameters.
     KeymasterOperation begin(
             keymaster_purpose_t purpose,
@@ -100,9 +100,9 @@
 }
 
 template <keymaster_tag_t Tag>
-inline void addStringParam(AuthorizationSetBuilder &params,
+inline void addStringParam(AuthorizationSetBuilder *params,
         TypedTag<KM_BYTES, Tag> tag, const std::string& val) {
-    params.Authorization(tag, val.data(), val.size());
+    params->Authorization(tag, val.data(), val.size());
 }
 
 }  // namespace vold