commit 5cc0d564c8277a11a066188e03e7100cf1b9f04d
author Sudheer Shanka <sudheersai@google.com> Tue Aug 07 19:09:06 2018 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Tue Aug 07 19:09:06 2018 +0000
tree efb132b2c501be5c6013b8e6e542408f40e8b733
parent 0ba33ed3dbdfd3ea2ec31aa07878492d75f3ba5f
parent f768c271a3a817c9a60b7454631a42d065eb36af

Merge "Update sandbox structure for apps with sharedUserIds."

VolumeManager.cpp

diff --git a/VolumeManager.cpp b/VolumeManager.cpp
index e744c19..594fcde 100644
--- a/VolumeManager.cpp
+++ b/VolumeManager.cpp
@@ -406,6 +406,13 @@
     if (sandboxRoot.empty()) {
         return -errno;
     }
+    std::string sharedSandboxRoot;
+    StringAppendF(&sharedSandboxRoot, "%s/shared", sandboxRoot.c_str());
+    // Create shared sandbox base dir for apps with sharedUserIds
+    if (fs_prepare_dir(sharedSandboxRoot.c_str(), 0700, AID_ROOT, AID_ROOT) != 0) {
+        PLOG(ERROR) << "fs_prepare_dir failed on " << sharedSandboxRoot;
+        return -errno;
+    }
 
     std::string dataRoot = prepareSubDirs(primaryRoot, "Android/data/",
             0700, AID_ROOT, AID_ROOT);
@@ -511,8 +518,12 @@
 
 std::string VolumeManager::prepareSandboxSource(uid_t uid, const std::string& sandboxId,
         const std::string& sandboxRootDir) {
-    std::string sandboxSourceDir = StringPrintf("%s/%s",
-            sandboxRootDir.c_str(), sandboxId.c_str());
+    std::string sandboxSourceDir(sandboxRootDir);
+    if (android::base::StartsWith(sandboxId, "shared:")) {
+        StringAppendF(&sandboxSourceDir, "/shared/%s", sandboxId.substr(7).c_str());
+    } else {
+        StringAppendF(&sandboxSourceDir, "/%s", sandboxId.c_str());
+    }
     if (fs_prepare_dir(sandboxSourceDir.c_str(), 0755, uid, uid) != 0) {
         PLOG(ERROR) << "fs_prepare_dir failed on " << sandboxSourceDir;
         return kEmptyString;