commit 5540b4406c2ca9c5a3654cabc1ab7e88afde58b5
author Jeff Sharkey <jsharkey@android.com> Sat Feb 24 18:09:21 2018 -0700
committer Jeff Sharkey <jsharkey@android.com> Sat Feb 24 18:09:22 2018 -0700
tree d9608be0b7eea8fe6138497dbb703ca8971e603a
parent 8c26c46059adfc09f87a15fa7ada8b5492ceced1

Use unique_ptr<DIR> to safely release resources.

Test: builds, boots
Bug: 66995913
Change-Id: Ib580501fc979b63295b180250581dc7527de76b2

Loop.cpp

diff --git a/Loop.cpp b/Loop.cpp
index 3736d6a..335ca13 100644
--- a/Loop.cpp
+++ b/Loop.cpp
@@ -110,17 +110,16 @@
 int Loop::destroyAll() {
     ATRACE_NAME("Loop::destroyAll");
 
-    DIR* dir;
-    struct dirent* de;
-
     std::string root = "/dev/block/";
-    if (!(dir = opendir(root.c_str()))) {
+    auto dirp = std::unique_ptr<DIR, int (*)(DIR*)>(opendir(root.c_str()), closedir);
+    if (!dirp) {
         PLOG(ERROR) << "Failed to opendir";
         return -1;
     }
 
     // Poke through all devices looking for loops
-    while ((de = readdir(dir))) {
+    struct dirent* de;
+    while ((de = readdir(dirp.get()))) {
         auto test = std::string(de->d_name);
         if (!android::base::StartsWith(test, "loop")) continue;
 
@@ -151,7 +150,6 @@
         }
     }
 
-    closedir(dir);
     return 0;
 }