Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_system_vold / 2711bf7059318aa6a61e37392a0aee6263bff0a0
commit2711bf7059318aa6a61e37392a0aee6263bff0a0[log] [tgz]
authornift4 <nift4@protonmail.com>Sat Jul 01 11:49:12 2023 +0200
committernift4 <nift4@protonmail.com>Sat Jul 01 12:21:24 2023 +0200
tree76d53a8ab1e4d442185af5e4929922726a8b2b18
parent44775a24756192072d3dc68444d0f8968da7b8f2 [diff]
vold: fix failing to format zero-ed out SD card

sgdisk --android-dump fails with error code 8 when there is no partition
table. Don't stop us from creating a new partition table.

Can be reproduced with
1. adb shell sm set-virtual-disk true
2. Format from UI
3. Observe fake "success" message with SD still unformatted

Fixes: ad5b4f9 ("vold: skip first disk change when converting MBR to GPT")
Test: CtsOsTestCases android.os.storage.cts.StorageManagerTest#testGetStorageVolumeSDCard
Change-Id: I3262bb2e28de438beba541a97038a06432643a65
1 file changed
tree: 76d53a8ab1e4d442185af5e4929922726a8b2b18
  1. bench/
  2. binder/
  3. fs/
  4. model/
  5. tests/
  6. .clang-format ⇨ ../../build/soong/scripts/system-clang-format
  7. Android.bp
  8. AppFuseUtil.cpp
  9. AppFuseUtil.h
  10. Benchmark.cpp
  11. Benchmark.h
  12. BenchmarkGen.h
  13. Checkpoint.cpp
  14. Checkpoint.h
  15. CleanSpec.mk
  16. cryptfs.cpp
  17. cryptfs.h
  18. CryptoType.cpp
  19. CryptoType.h
  20. EncryptInplace.cpp
  21. EncryptInplace.h
  22. FileDeviceUtils.cpp
  23. FileDeviceUtils.h
  24. FsCrypt.cpp
  25. FsCrypt.h
  26. IdleMaint.cpp
  27. IdleMaint.h
  28. KeyBuffer.cpp
  29. KeyBuffer.h
  30. KeyStorage.cpp
  31. KeyStorage.h
  32. Keystore.cpp
  33. Keystore.h
  34. KeyUtil.cpp
  35. KeyUtil.h
  36. Loop.cpp
  37. Loop.h
  38. main.cpp
  39. MetadataCrypt.cpp
  40. MetadataCrypt.h
  41. MoveStorage.cpp
  42. MoveStorage.h
  43. NetlinkHandler.cpp
  44. NetlinkHandler.h
  45. NetlinkManager.cpp
  46. NetlinkManager.h
  47. OWNERS
  48. PREUPLOAD.cfg
  49. Process.cpp
  50. Process.h
  51. secdiscard.cpp
  52. sehandle.h
  53. TEST_MAPPING
  54. Utils.cpp
  55. Utils.h
  56. vdc.cpp
  57. vold.rc
  58. vold_prepare_subdirs.cpp
  59. VoldNativeService.cpp
  60. VoldNativeService.h
  61. VoldNativeServiceValidation.cpp
  62. VoldNativeServiceValidation.h
  63. VoldUtil.cpp
  64. VoldUtil.h
  65. VolumeManager.cpp
  66. VolumeManager.h