Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_system_vold / 18eb8772467d45a234cd4343a4e9a45cb938d996
commit18eb8772467d45a234cd4343a4e9a45cb938d996[log] [tgz]
authorYurii Zubrytskyi <zyy@google.com>Mon Oct 18 22:33:15 2021 -0700
committerAlex Buynytskyy <alexbuy@google.com>Mon Jan 31 22:13:14 2022 +0000
tree9d367be630c1eebb27be99c4b9a01fdc6f55c7fd
parent313e8556a6fe5b23f4cc0e83fbdc2b0933f5d65c [diff]
[vold] Check incremental paths before mounting

Vold was trusting system_server too much and allowed for pretty
much any path in mount()/bindMount() calls for incremental.
This CL adds validation to make sure it's only accessing own
directories. This includes enforcing no symlinks in the paths

Bug: 198657657
Bug: 216722132
Test: manual
Change-Id: I6035447f94ef44c4ae3294c3ae47de2d7210683a
Merged-In: I6035447f94ef44c4ae3294c3ae47de2d7210683a
5 files changed
tree: 9d367be630c1eebb27be99c4b9a01fdc6f55c7fd
  1. bench/
  2. binder/
  3. fs/
  4. model/
  5. tests/
  6. .clang-format ⇨ ../../build/soong/scripts/system-clang-format
  7. Android.bp
  8. AppFuseUtil.cpp
  9. AppFuseUtil.h
  10. Benchmark.cpp
  11. Benchmark.h
  12. BenchmarkGen.h
  13. Checkpoint.cpp
  14. Checkpoint.h
  15. CleanSpec.mk
  16. cryptfs.cpp
  17. cryptfs.h
  18. CryptoType.cpp
  19. CryptoType.h
  20. Devmapper.cpp
  21. Devmapper.h
  22. EncryptInplace.cpp
  23. EncryptInplace.h
  24. FileDeviceUtils.cpp
  25. FileDeviceUtils.h
  26. FsCrypt.cpp
  27. FsCrypt.h
  28. IdleMaint.cpp
  29. IdleMaint.h
  30. KeyBuffer.cpp
  31. KeyBuffer.h
  32. KeyStorage.cpp
  33. KeyStorage.h
  34. Keystore.cpp
  35. Keystore.h
  36. KeyUtil.cpp
  37. KeyUtil.h
  38. Loop.cpp
  39. Loop.h
  40. main.cpp
  41. MetadataCrypt.cpp
  42. MetadataCrypt.h
  43. MoveStorage.cpp
  44. MoveStorage.h
  45. NetlinkHandler.cpp
  46. NetlinkHandler.h
  47. NetlinkManager.cpp
  48. NetlinkManager.h
  49. OWNERS
  50. PREUPLOAD.cfg
  51. Process.cpp
  52. Process.h
  53. secdiscard.cpp
  54. sehandle.h
  55. TEST_MAPPING
  56. Utils.cpp
  57. Utils.h
  58. vdc.cpp
  59. vold.rc
  60. vold_prepare_subdirs.cpp
  61. VoldNativeService.cpp
  62. VoldNativeService.h
  63. VoldNativeServiceValidation.cpp
  64. VoldNativeServiceValidation.h
  65. VoldUtil.cpp
  66. VoldUtil.h
  67. VolumeManager.cpp
  68. VolumeManager.h