tree ad6dd514ff8b2680a5b52ad66b34a04ab6ba33c9
parent 67db7b9786be3c1f6fbdf8148faa7db90dc824d6
author Eric Biggers <ebiggers@google.com> 1623182100 -0700
committer Eric Biggers <ebiggers@google.com> 1623193051 -0700

Make RenameKeyDir() use IsSameFile()

Comparing paths is error-prone (e.g. "/foo/bar" vs "/foo//bar"), so
entries in key_dirs_to_commit are compared using inode and device
number.  However RenameKeyDir() breaks this rule and compares raw paths.

Avoid this quirk by finding the entry in the list to replace before
doing the rename.

This doesn't fix any known problem, as vold is fairly consistent with
its paths in practice; this is just a robustness improvement.

Bug: 190398249
Change-Id: I3ce2c0119cb2012ac9d12849570e56600bc23867