commit 0ef7bfd59c0a97b39b2e1152da30db4e96e3a915
author Eric Biggers <ebiggers@google.com> Wed Jan 16 13:05:34 2019 -0800
committer Eric Biggers <ebiggers@google.com> Fri Jan 18 13:24:30 2019 -0800
tree 72307f12e28b8201d3a5736ecbf4189d561199fd
parent 9f7aa175a0fa2a96f4fe14cdc64011c229b457a7

Utils: correctly handle read() errors in ReadRandomBytes()

read() returns -1 on error, so we need to use a signed type.

Test: Booted device with FDE
Change-Id: Ib44247c1cdfd38674a7439209e333823f2fb6cf8

Utils.cpp

diff --git a/Utils.cpp b/Utils.cpp
index 4464afc..f00d168 100644
--- a/Utils.cpp
+++ b/Utils.cpp
@@ -377,7 +377,7 @@
         return -errno;
     }
 
-    size_t n;
+    ssize_t n;
     while ((n = TEMP_FAILURE_RETRY(read(fd, &buf[0], bytes))) > 0) {
         bytes -= n;
         buf += n;