Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_system_vold / 01a0e7fa189b37b82be971bc50ecce5883523293
commit01a0e7fa189b37b82be971bc50ecce5883523293[log] [tgz]
authorJeff Sharkey <jsharkey@android.com>Tue Oct 17 16:06:32 2017 -0600
committerJeff Sharkey <jsharkey@android.com>Wed Oct 18 11:44:57 2017 -0600
treea88f91865e74211b89f6678eaa2f65a900e53dcc
parenta6f628587523624d03ba78f49d2aff6f57368d99 [diff]
Fix task memory leaks; better path validation.

We've been allocating task objects without freeing them, oops.  We
don't really need full classes for these tasks, so move them to
blocking methods, and invoke them from a detached thread.

Remove FIDTRIM support, which isn't meaningful on UFS-based flash
devices.  Modern devices require FBE/FDE which gives us better
protection against trimmed data lingering around.

Rename "Trim" to more generic "IdleMaint", since it'll soon extend
to include custom F2FS optimization logic.

Check for shady ".." when validating paths.

Test: cts-tradefed run commandAndExit cts-dev -m CtsOsTestCases -t android.os.storage.cts.StorageManagerTest
Test: cts-tradefed run commandAndExit cts-dev --abi armeabi-v7a -m CtsAppSecurityHostTestCases -t android.appsecurity.cts.AdoptableHostTest
Bug: 67041047
Change-Id: I4fb194c5d5ef13f413c02acedfbaaf79c567582b
10 files changed
tree: a88f91865e74211b89f6678eaa2f65a900e53dcc
  1. bench/
  2. binder/
  3. fs/
  4. model/
  5. tests/
  6. Android.mk
  7. Benchmark.cpp
  8. Benchmark.h
  9. BenchmarkGen.h
  10. CleanSpec.mk
  11. cryptfs.cpp
  12. cryptfs.h
  13. Devmapper.cpp
  14. Devmapper.h
  15. EncryptInplace.cpp
  16. EncryptInplace.h
  17. Ext4Crypt.cpp
  18. Ext4Crypt.h
  19. FileDeviceUtils.cpp
  20. FileDeviceUtils.h
  21. hash.h
  22. IdleMaint.cpp
  23. IdleMaint.h
  24. KeyBuffer.cpp
  25. KeyBuffer.h
  26. Keymaster.cpp
  27. Keymaster.h
  28. KeyStorage.cpp
  29. KeyStorage.h
  30. KeyUtil.cpp
  31. KeyUtil.h
  32. Loop.cpp
  33. Loop.h
  34. main.cpp
  35. MetadataCrypt.cpp
  36. MetadataCrypt.h
  37. MoveStorage.cpp
  38. MoveStorage.h
  39. NetlinkHandler.cpp
  40. NetlinkHandler.h
  41. NetlinkManager.cpp
  42. NetlinkManager.h
  43. OWNERS
  44. prepare_dir.cpp
  45. Process.cpp
  46. Process.h
  47. ScryptParameters.cpp
  48. ScryptParameters.h
  49. secdiscard.cpp
  50. secontext.cpp
  51. secontext.h
  52. sehandle.h
  53. Utils.cpp
  54. Utils.h
  55. vdc.cpp
  56. vdc.rc
  57. vold.rc
  58. vold_prepare_subdirs
  59. VoldNativeService.cpp
  60. VoldNativeService.h
  61. VoldUtil.cpp
  62. VoldUtil.h
  63. VolumeManager.cpp
  64. VolumeManager.h