update_engine: Remove zlib fingerprint checking
This is not needed as imgdiff is not being used and will be replaced by
puffin.
Presence of this code makes updating to newer version of zlib
impossible. (e.g. 1.2.8->1.2.11 update introduces some changes in
compression algorithm which make compressed output different).
BUG=None
TEST="ebuild zlib.ebuild test"
Change-Id: I50793f552a44faaba5771271fdcf2b4f4aeba6e4
Reviewed-on: https://chromium-review.googlesource.com/522949
Commit-Ready: Andrey Ulanov <andreyu@google.com>
Tested-by: Andrey Ulanov <andreyu@google.com>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>
diff --git a/common/utils.cc b/common/utils.cc
index f528660..f651823 100644
--- a/common/utils.cc
+++ b/common/utils.cc
@@ -57,7 +57,6 @@
#include "update_engine/common/prefs_interface.h"
#include "update_engine/common/subprocess.h"
#include "update_engine/payload_consumer/file_descriptor.h"
-#include "update_engine/payload_consumer/payload_constants.h"
using base::Time;
using base::TimeDelta;
@@ -1035,19 +1034,6 @@
return false;
}
-bool IsZlibCompatible(const string& fingerprint) {
- if (fingerprint.size() != sizeof(kCompatibleZlibFingerprint[0]) - 1) {
- LOG(ERROR) << "Invalid fingerprint: " << fingerprint;
- return false;
- }
- for (auto& f : kCompatibleZlibFingerprint) {
- if (base::CompareCaseInsensitiveASCII(fingerprint, f) == 0) {
- return true;
- }
- }
- return false;
-}
-
bool ReadExtents(const string& path, const vector<Extent>& extents,
brillo::Blob* out_data, ssize_t out_data_size,
size_t block_size) {
diff --git a/common/utils.h b/common/utils.h
index eaf2640..2117836 100644
--- a/common/utils.h
+++ b/common/utils.h
@@ -308,9 +308,6 @@
bool GetMinorVersion(const brillo::KeyValueStore& store,
uint32_t* minor_version);
-// Returns whether zlib |fingerprint| is compatible with zlib we are using.
-bool IsZlibCompatible(const std::string& fingerprint);
-
// This function reads the specified data in |extents| into |out_data|. The
// extents are read from the file at |path|. |out_data_size| is the size of
// |out_data|. Returns false if the number of bytes to read given in
diff --git a/payload_consumer/delta_performer_unittest.cc b/payload_consumer/delta_performer_unittest.cc
index 1e06e1a..6f3d89e 100644
--- a/payload_consumer/delta_performer_unittest.cc
+++ b/payload_consumer/delta_performer_unittest.cc
@@ -818,20 +818,4 @@
EXPECT_EQ(DeltaPerformer::kSupportedMajorPayloadVersion, major_version);
}
-// Test that we recognize our own zlib compressor implementation as supported.
-// All other equivalent implementations should be added to
-// kCompatibleZlibFingerprint.
-TEST_F(DeltaPerformerTest, ZlibFingerprintMatch) {
- string fingerprint;
-#ifdef __ANDROID__
- const std::string kZlibFingerprintPath =
- test_utils::GetBuildArtifactsPath("zlib_fingerprint");
-#else
- const std::string kZlibFingerprintPath = "/etc/zlib_fingerprint";
-#endif // __ANDROID__
- EXPECT_TRUE(base::ReadFileToString(base::FilePath(kZlibFingerprintPath),
- &fingerprint));
- EXPECT_TRUE(utils::IsZlibCompatible(fingerprint));
-}
-
} // namespace chromeos_update_engine
diff --git a/payload_consumer/payload_constants.cc b/payload_consumer/payload_constants.cc
index de0fd74..4c11d7a 100644
--- a/payload_consumer/payload_constants.cc
+++ b/payload_consumer/payload_constants.cc
@@ -32,17 +32,6 @@
const char kDeltaMagic[4] = {'C', 'r', 'A', 'U'};
-// The zlib in Android and Chrome OS are currently compatible with each other,
-// so they are sharing the same array, but if in the future they are no longer
-// compatible with each other, we coule make the same change on the other one to
-// make them compatible again or use ifdef here.
-const char kCompatibleZlibFingerprint[][65] = {
- "ea973605ccbbdb24f59f449c5f65861a1a9bc7a4353377aaaa06cb3e0f1cfbd7",
- "3747fa404cceb00a5ec3606fc779510aaa784d5864ab1d5c28b9e267c40aad5c",
- // zlib 1.2.11
- "61514794a2985bee78135fd67a2f1fd18e56f3c3e410fbc4552a0e05a701e47a",
-};
-
const char* InstallOperationTypeName(InstallOperation_Type op_type) {
switch (op_type) {
case InstallOperation::BSDIFF:
diff --git a/payload_consumer/payload_constants.h b/payload_consumer/payload_constants.h
index 7509ed2..76d740f 100644
--- a/payload_consumer/payload_constants.h
+++ b/payload_consumer/payload_constants.h
@@ -56,15 +56,6 @@
extern const char kBspatchPath[];
extern const char kDeltaMagic[4];
-// The list of compatible SHA256 hashes of zlib source code.
-// This is used to check if the source image have a compatible zlib (produce
-// same compressed result given the same input).
-// When a new fingerprint is found, please examine the changes in zlib source
-// carefully and determine if it's still compatible with previous version, if
-// yes then add the new fingerprint to this array, otherwise remove all previous
-// fingerprints in the array first, and only include the new fingerprint.
-extern const char kCompatibleZlibFingerprint[3][65];
-
// A block number denoting a hole on a sparse file. Used on Extents to refer to
// section of blocks not present on disk on a sparse file.
const uint64_t kSparseHole = std::numeric_limits<uint64_t>::max();
diff --git a/payload_generator/generate_delta_main.cc b/payload_generator/generate_delta_main.cc
index 3bd9ee6..a3c71b0 100644
--- a/payload_generator/generate_delta_main.cc
+++ b/payload_generator/generate_delta_main.cc
@@ -324,9 +324,6 @@
DEFINE_string(properties_file, "",
"If passed, dumps the payload properties of the payload passed "
"in --in_file and exits.");
- DEFINE_string(zlib_fingerprint, "",
- "The fingerprint of zlib in the source image in hash string "
- "format, used to check imgdiff compatibility.");
DEFINE_string(old_channel, "",
"The channel for the old image. 'dev-channel', 'npo-channel', "
@@ -570,14 +567,6 @@
LOG(INFO) << "Using provided minor_version=" << FLAGS_minor_version;
}
- if (!FLAGS_zlib_fingerprint.empty()) {
- if (utils::IsZlibCompatible(FLAGS_zlib_fingerprint)) {
- payload_config.version.imgdiff_allowed = true;
- } else {
- LOG(INFO) << "IMGDIFF operation disabled due to fingerprint mismatch.";
- }
- }
-
if (payload_config.is_delta) {
LOG(INFO) << "Generating delta update";
} else {
diff --git a/scripts/brillo_update_payload b/scripts/brillo_update_payload
index e62ba94..b139491 100755
--- a/scripts/brillo_update_payload
+++ b/scripts/brillo_update_payload
@@ -210,9 +210,6 @@
# Path to the postinstall config file in target image if exists.
POSTINSTALL_CONFIG_FILE=""
-# The fingerprint of zlib in the source image.
-ZLIB_FINGERPRINT=""
-
# read_option_int <file.txt> <option_key> [default_value]
#
# Reads the unsigned integer value associated with |option_key| in a key=value
@@ -332,11 +329,6 @@
# updater supports a newer major version.
FORCE_MAJOR_VERSION="1"
- if [[ "${partitions_array}" == "SRC_PARTITIONS" ]]; then
- # Copy from zlib_fingerprint in source image to stdout.
- ZLIB_FINGERPRINT=$(e2cp "${root}":/etc/zlib_fingerprint -)
- fi
-
# When generating legacy Chrome OS images, we need to use "boot" and "system"
# for the partition names to be compatible with updating Brillo devices with
# Chrome OS images.
@@ -410,10 +402,6 @@
Disabling deltas for this source version."
exit ${EX_UNSUPPORTED_DELTA}
fi
-
- if [[ "${FORCE_MINOR_VERSION}" -ge 4 ]]; then
- ZLIB_FINGERPRINT=$(unzip -p "${image}" "META/zlib_fingerprint.txt")
- fi
else
# Target image
local postinstall_config=$(create_tempfile "postinstall_config.XXXXXX")
@@ -535,9 +523,6 @@
if [[ -n "${FORCE_MINOR_VERSION}" ]]; then
GENERATOR_ARGS+=( --minor_version="${FORCE_MINOR_VERSION}" )
fi
- if [[ -n "${ZLIB_FINGERPRINT}" ]]; then
- GENERATOR_ARGS+=( --zlib_fingerprint="${ZLIB_FINGERPRINT}" )
- fi
fi
if [[ -n "${FORCE_MAJOR_VERSION}" ]]; then