Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_system_update_engine / 8adc24346405a142e7d3b65c3e4aee0515320f73
commit8adc24346405a142e7d3b65c3e4aee0515320f73[log] [tgz]
authorSen Jiang <senj@google.com>Tue Aug 15 18:20:24 2017 -0700
committerchrome-bot <chrome-bot@chromium.org>Thu Jan 04 21:52:07 2018 -0800
tree8317393ef148c9ce6bbc83e8ff1ff8715f43ab05
parent5a652867dceedb7bba3e840403a00d9a1ed9e0f8 [diff]
Fix pylint warnings in update_device.py

We weren't actually using our own pylintrc file in repo upload hook,
which will be fixed by https://android-review.googlesource.com/#/c/platform/tools/repohooks/+/458996/

Even though both camel case and snake case are allowed for function
and method names, they still have to be consistent in a single file.
https://pylint.readthedocs.io/en/latest/user_guide/options.html#multiple-naming-styles

Bug: 27316596
Test: repo upload
Change-Id: I98adba957a547115ef3d8b00fe2e3e4931707b31
(cherry picked from commit 1048559a5c8b6c897aee6c8095035fc7724ae340)
Reviewed-on: https://chromium-review.googlesource.com/848502
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>
2 files changed
tree: 8317393ef148c9ce6bbc83e8ff1ff8715f43ab05
  1. binder_bindings/
  2. client_library/
  3. common/
  4. dbus_bindings/
  5. init/
  6. payload_consumer/
  7. payload_generator/
  8. sample_images/
  9. scripts/
  10. update_manager/
  11. update_payload_key/
  12. .clang-format ⇨ ../../../platform2/common-mk/brillo-clang-format
  13. .gitignore
  14. Android.mk
  15. binder_service_android.cc
  16. binder_service_android.h
  17. binder_service_brillo.cc
  18. binder_service_brillo.h
  19. boot_control_android.cc
  20. boot_control_android.h
  21. boot_control_chromeos.cc
  22. boot_control_chromeos.h
  23. boot_control_chromeos_unittest.cc
  24. boot_control_recovery.cc
  25. boot_control_recovery.h
  26. boot_control_recovery_stub.cc
  27. certificate_checker.cc
  28. certificate_checker.h
  29. certificate_checker_unittest.cc
  30. chrome_browser_proxy_resolver.cc
  31. chrome_browser_proxy_resolver.h
  32. COMMIT-QUEUE.ini
  33. common_service.cc
  34. common_service.h
  35. common_service_unittest.cc
  36. connection_manager.cc
  37. connection_manager.h
  38. connection_manager_android.cc
  39. connection_manager_android.h
  40. connection_manager_interface.h
  41. connection_manager_unittest.cc
  42. connection_utils.cc
  43. connection_utils.h
  44. CPPLINT.cfg
  45. daemon.cc
  46. daemon.h
  47. daemon_state_android.cc
  48. daemon_state_android.h
  49. daemon_state_interface.h
  50. dbus_connection.cc
  51. dbus_connection.h
  52. dbus_service.cc
  53. dbus_service.h
  54. dbus_test_utils.h
  55. fake_file_writer.h
  56. fake_p2p_manager.h
  57. fake_p2p_manager_configuration.h
  58. fake_shill_proxy.cc
  59. fake_shill_proxy.h
  60. fake_system_state.cc
  61. fake_system_state.h
  62. generate_pc_file.sh
  63. hardware_android.cc
  64. hardware_android.h
  65. hardware_chromeos.cc
  66. hardware_chromeos.h
  67. hardware_chromeos_unittest.cc
  68. image_properties.h
  69. image_properties_android.cc
  70. image_properties_chromeos.cc
  71. image_properties_chromeos_unittest.cc
  72. libcurl_http_fetcher.cc
  73. libcurl_http_fetcher.h
  74. libupdate_engine-client-test.pc.in
  75. libupdate_engine-client.pc.in
  76. local_coverage_rate
  77. main.cc
  78. metrics.cc
  79. metrics.h
  80. metrics_utils.cc
  81. metrics_utils.h
  82. metrics_utils_unittest.cc
  83. mock_certificate_checker.h
  84. mock_connection_manager.h
  85. mock_file_writer.h
  86. mock_omaha_request_params.h
  87. mock_p2p_manager.h
  88. mock_payload_state.h
  89. mock_power_manager.h
  90. mock_proxy_resolver.h
  91. mock_update_attempter.h
  92. MODULE_LICENSE_APACHE2
  93. network_selector.h
  94. network_selector_android.cc
  95. network_selector_android.h
  96. network_selector_interface.h
  97. network_selector_stub.cc
  98. network_selector_stub.h
  99. NOTICE
  100. omaha_request_action.cc
  101. omaha_request_action.h
  102. omaha_request_action_unittest.cc
  103. omaha_request_params.cc
  104. omaha_request_params.h
  105. omaha_request_params_unittest.cc
  106. omaha_response.h
  107. omaha_response_handler_action.cc
  108. omaha_response_handler_action.h
  109. omaha_response_handler_action_unittest.cc
  110. omaha_utils.cc
  111. omaha_utils.h
  112. omaha_utils_unittest.cc
  113. OWNERS
  114. p2p_manager.cc
  115. p2p_manager.h
  116. p2p_manager_unittest.cc
  117. parcelable_update_engine_status.cc
  118. parcelable_update_engine_status.h
  119. payload_state.cc
  120. payload_state.h
  121. payload_state_interface.h
  122. payload_state_unittest.cc
  123. power_manager_android.cc
  124. power_manager_android.h
  125. power_manager_chromeos.cc
  126. power_manager_chromeos.h
  127. power_manager_interface.h
  128. PRESUBMIT.cfg
  129. PREUPLOAD.cfg
  130. proxy_resolver.cc
  131. proxy_resolver.h
  132. proxy_resolver_unittest.cc
  133. pylintrc
  134. real_system_state.cc
  135. real_system_state.h
  136. run_unittests
  137. sample_omaha_v3_response.xml
  138. service_delegate_android_interface.h
  139. service_observer_interface.h
  140. shill_proxy.cc
  141. shill_proxy.h
  142. shill_proxy_interface.h
  143. sideload_main.cc
  144. system_state.h
  145. tar_bunzip2.gypi
  146. test_http_server.cc
  147. test_subprocess.cc
  148. testrunner.cc
  149. unittest_key.pem
  150. unittest_key2.pem
  151. update_attempter.cc
  152. update_attempter.h
  153. update_attempter_android.cc
  154. update_attempter_android.h
  155. update_attempter_unittest.cc
  156. update_engine-client.gyp
  157. update_engine.conf
  158. update_engine.gyp
  159. update_engine.rc
  160. update_engine_client.cc
  161. update_engine_client_android.cc
  162. update_metadata.proto
  163. update_status_utils.cc
  164. update_status_utils.h
  165. UpdateEngine.conf
  166. utils_android.cc
  167. utils_android.h
  168. WATCHLISTS