update_engine: update to libbase 242728
Made update_engine link with libchrome-242728 and fixed compile
issues due to changes in namespaces and include file layout.
Also removed some of suppressed compiler warnings and fixed the
issues masked by them (e.g. mismatched printf-like specifiers).
Added -Wextra compiler option to enable additional useful warnings
to ensure more strict checking... Had to disable "unused-parameter"
though since we have a lot of functions (mainly in fakes) that do
not use all of their parameters.
BUG=chromium:351593
TEST=Unit tests passed.
CQ-DEPEND=CL:191721
Change-Id: I1aa63a48d5f1f4ea75ba6b00aec7aa5f3bad15c4
Reviewed-on: https://chromium-review.googlesource.com/191510
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
diff --git a/prefs.h b/prefs.h
index e119389..f05da0a 100644
--- a/prefs.h
+++ b/prefs.h
@@ -5,7 +5,7 @@
#ifndef CHROMEOS_PLATFORM_UPDATE_ENGINE_PREFS_H_
#define CHROMEOS_PLATFORM_UPDATE_ENGINE_PREFS_H_
-#include "base/file_path.h"
+#include <base/files/file_path.h>
#include "gtest/gtest_prod.h" // for FRIEND_TEST
#include "update_engine/prefs_interface.h"
@@ -22,7 +22,7 @@
// Initializes the store by associating this object with |prefs_dir|
// as the preference store directory. Returns true on success, false
// otherwise.
- bool Init(const FilePath& prefs_dir);
+ bool Init(const base::FilePath& prefs_dir);
// PrefsInterface methods.
bool GetString(const std::string& key, std::string* value);
@@ -42,10 +42,10 @@
// Sets |filename| to the full path to the file containing the data
// associated with |key|. Returns true on success, false otherwise.
- bool GetFileNameForKey(const std::string& key, FilePath* filename);
+ bool GetFileNameForKey(const std::string& key, base::FilePath* filename);
// Preference store directory.
- FilePath prefs_dir_;
+ base::FilePath prefs_dir_;
DISALLOW_COPY_AND_ASSIGN(Prefs);
};