commit 5d95615688e7c99644b3679129d91f0c38e2eb95
author Zentaro Kavanagh <zentaro@chromium.org> Tue May 15 09:40:33 2018 -0700
committer chrome-bot <chrome-bot@chromium.org> Wed May 16 12:41:24 2018 -0700
tree a3cf0c123d014b3b733f714c70d5faebc27e1ec0
parent c288206aac04194cbeca0338c032283a0869e810

update_engine: Fix TPM variable name max_kernel_rollfoward

- In a previous CL I named the variable incorrectly

BUG=chromium:814090
TEST=FEATURES=test emerge-samus update_engine

Change-Id: I17cbc85d42ba03040bfdae436cedd0238698b47e
Reviewed-on: https://chromium-review.googlesource.com/1059944
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

omaha_request_action_unittest.cc

diff --git a/omaha_request_action_unittest.cc b/omaha_request_action_unittest.cc
index a70712a..2ad3eec 100644
--- a/omaha_request_action_unittest.cc
+++ b/omaha_request_action_unittest.cc
@@ -2801,7 +2801,7 @@
                     3 /* rollback_allowed_milestones */,
                     false /* is_policy_loaded */);
 
-  // Verify max_kernel_rollforward was set to the current minimum
+  // Verify kernel_max_rollforward was set to the current minimum
   // kernel key version. This has the effect of freezing roll
   // forwards indefinitely. This will hold the rollback window
   // open until a future change will be able to move this forward
@@ -2828,7 +2828,7 @@
                     3 /* rollback_allowed_milestones */,
                     false /* is_policy_loaded */);
 
-  // Verify that with rollback disabled that max_kernel_rollforward
+  // Verify that with rollback disabled that kernel_max_rollforward
   // was set to logical infinity. This is the expected behavior for
   // consumer devices and matches the existing behavior prior to the
   // rollback features.
@@ -2836,7 +2836,7 @@
   EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());
 }
 
-// Verifies that a device with rollback enabled sets max_kernel_rollforward
+// Verifies that a device with rollback enabled sets kernel_max_rollforward
 // in the TPM to prevent roll forward.
 TEST_F(OmahaRequestActionTest, RollbackEnabledDevicesSetMaxRollback) {
   FakeHardware* fake_hw = fake_system_state_.fake_hardware();
@@ -2854,7 +2854,7 @@
                     allowed_milestones,
                     true /* is_policy_loaded */);
 
-  // Verify that with rollback enabled that max_kernel_rollforward
+  // Verify that with rollback enabled that kernel_max_rollforward
   // was set to the current minimum kernel key version. This has
   // the effect of freezing roll forwards indefinitely. This will
   // hold the rollback window open until a future change will
@@ -2863,7 +2863,7 @@
   EXPECT_EQ(min_kernel_version, fake_hw->GetMaxKernelKeyRollforward());
 }
 
-// Verifies that a device with rollback disabled sets max_kernel_rollforward
+// Verifies that a device with rollback disabled sets kernel_max_rollforward
 // in the TPM to logical infinity, to allow roll forward.
 TEST_F(OmahaRequestActionTest, RollbackDisabledDevicesSetMaxRollback) {
   FakeHardware* fake_hw = fake_system_state_.fake_hardware();
@@ -2881,7 +2881,7 @@
                     allowed_milestones,
                     true /* is_policy_loaded */);
 
-  // Verify that with rollback disabled that max_kernel_rollforward
+  // Verify that with rollback disabled that kernel_max_rollforward
   // was set to logical infinity.
   EXPECT_EQ(min_kernel_version, fake_hw->GetMinKernelKeyVersion());
   EXPECT_EQ(kRollforwardInfinity, fake_hw->GetMaxKernelKeyRollforward());