Fix support finding global variables.
The code was not properly getting the variable addresses and using
the offset and address fields of the .data section.
Fix all of that, and update the tests.
Bug: 145162678
Test: Unit tests pass.
Test: ./art/test/run-test --dex2oat-jobs 4 --host --prebuild --compact-dex-level fast --jit --no-relocate --runtime-option -Xcheck:jni 137-cfi
Test: ./art/test/testrunner/testrunner.py -t 137 --host
Change-Id: Ic61c4487334fd2273cda9c56eb1a3b525a03edb7
diff --git a/libunwindstack/Elf.cpp b/libunwindstack/Elf.cpp
index c141b2e..6627787 100644
--- a/libunwindstack/Elf.cpp
+++ b/libunwindstack/Elf.cpp
@@ -112,35 +112,33 @@
gnu_debugdata_interface_->GetFunctionName(addr, name, func_offset)));
}
-bool Elf::GetGlobalVariable(const std::string& name, uint64_t* memory_address) {
+bool Elf::GetGlobalVariableOffset(const std::string& name, uint64_t* memory_offset) {
if (!valid_) {
return false;
}
- if (!interface_->GetGlobalVariable(name, memory_address) &&
+ uint64_t vaddr;
+ if (!interface_->GetGlobalVariable(name, &vaddr) &&
(gnu_debugdata_interface_ == nullptr ||
- !gnu_debugdata_interface_->GetGlobalVariable(name, memory_address))) {
+ !gnu_debugdata_interface_->GetGlobalVariable(name, &vaddr))) {
return false;
}
- // Adjust by the load bias.
- if (load_bias_ > 0 && *memory_address < static_cast<uint64_t>(load_bias_)) {
- return false;
+ // Check the .data section.
+ uint64_t vaddr_start = interface_->data_vaddr_start();
+ if (vaddr >= vaddr_start && vaddr < interface_->data_vaddr_end()) {
+ *memory_offset = vaddr - vaddr_start + interface_->data_offset();
+ return true;
}
- *memory_address -= load_bias_;
-
- // If this winds up in the dynamic section, then we might need to adjust
- // the address.
- uint64_t dynamic_end = interface_->dynamic_vaddr() + interface_->dynamic_size();
- if (*memory_address >= interface_->dynamic_vaddr() && *memory_address < dynamic_end) {
- if (interface_->dynamic_vaddr() > interface_->dynamic_offset()) {
- *memory_address -= interface_->dynamic_vaddr() - interface_->dynamic_offset();
- } else {
- *memory_address += interface_->dynamic_offset() - interface_->dynamic_vaddr();
- }
+ // Check the .dynamic section.
+ vaddr_start = interface_->dynamic_vaddr_start();
+ if (vaddr >= vaddr_start && vaddr < interface_->dynamic_vaddr_end()) {
+ *memory_offset = vaddr - vaddr_start + interface_->dynamic_offset();
+ return true;
}
- return true;
+
+ return false;
}
std::string Elf::GetBuildID() {