Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_packages_modules_adb / d727d31abd6b2dfcc45da4cf494e09b0106f5e45
commitd727d31abd6b2dfcc45da4cf494e09b0106f5e45[log] [tgz]
authorJosh Gao <jmgao@google.com>Fri Oct 05 17:09:07 2018 -0700
committerJosh Gao <jmgao@google.com>Fri Oct 05 17:23:44 2018 -0700
tree246fda34e44f05bbfac1d892a4953a4bdd14130a
parente3c42664284dd646e2a4cea344843c40f0b806ab [diff]
Revert "Revert "adb: detect some spin loops and abort.""

This reverts commit b701bfe4afc7da623c5439baf037a357919ecc3d.

The original incarnation of this patch was falsely triggering when our
poll would block with no activity happening for an extended amount of
time. When the poll returned, we would immediately flag that as a spin
loop. Solve this by tracking the last time we looped, to detect this.

While we're at it, switch from CLOCK_MONOTONIC to CLOCK_BOOTTIME, for
the same reason.

Change-Id: Ibcdf69d93f7b6012142cafd72066f39494c1f84b
Test: ./test_device.py
2 files changed
tree: 246fda34e44f05bbfac1d892a4953a4bdd14130a
  1. client/
  2. daemon/
  3. fastdeploy/
  4. sysdeps/
  5. .clang-format ⇨ ../.clang-format-4
  6. adb.bash
  7. adb.cpp
  8. adb.h
  9. adb_auth.h
  10. adb_integration_test_adb.xml
  11. adb_io.cpp
  12. adb_io.h
  13. adb_io_test.cpp
  14. adb_listeners.cpp
  15. adb_listeners.h
  16. adb_listeners_test.cpp
  17. adb_mdns.h
  18. adb_trace.cpp
  19. adb_trace.h
  20. adb_unique_fd.cpp
  21. adb_unique_fd.h
  22. adb_utils.cpp
  23. adb_utils.h
  24. adb_utils_test.cpp
  25. Android.bp
  26. Android.mk
  27. benchmark_device.py
  28. bugreport_test.cpp
  29. fdevent.cpp
  30. fdevent.h
  31. fdevent_test.cpp
  32. fdevent_test.h
  33. file_sync_protocol.h
  34. MODULE_LICENSE_APACHE2
  35. NOTICE
  36. OVERVIEW.TXT
  37. OWNERS
  38. protocol.txt
  39. security_log_tags.h
  40. services.cpp
  41. services.h
  42. SERVICES.TXT
  43. shell_protocol.h
  44. shell_service_protocol.cpp
  45. shell_service_protocol_test.cpp
  46. socket.h
  47. socket_spec.cpp
  48. socket_spec.h
  49. socket_spec_test.cpp
  50. socket_test.cpp
  51. sockets.cpp
  52. sockets.dia
  53. SYNC.TXT
  54. sysdeps.h
  55. sysdeps_test.cpp
  56. sysdeps_unix.cpp
  57. sysdeps_win32.cpp
  58. sysdeps_win32_test.cpp
  59. test_adb.py
  60. test_device.py
  61. trace.sh
  62. transport.cpp
  63. transport.h
  64. transport_benchmark.cpp
  65. transport_fd.cpp
  66. transport_local.cpp
  67. transport_test.cpp
  68. transport_usb.cpp
  69. types.h
  70. types_test.cpp
  71. usb.h