Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_packages_modules_adb / d0ccf885aa3d685d29ef61bf603272c19d674607
commitd0ccf885aa3d685d29ef61bf603272c19d674607[log] [tgz]
authorJosh Gao <jmgao@google.com>Thu Aug 17 13:50:51 2017 -0700
committerJosh Gao <jmgao@google.com>Wed Sep 27 14:35:52 2017 -0700
tree5c35ec741be18b1a34036000668d180d1be12471
parent7e3f2a9819eedf89e93550f2322942309ff4604c [diff]
adb: fix deadlock in kick_all_transports.

Previously, kick_all_transports would deadlock if there were any
inaccessible transports, because the transport kick function would call
unregister_usb_transport, which attempts to take the already-held
transport lock.

Fix this by switching the transport lock over to a recursive mutex.

Bug: 65419665
Test: manual
Change-Id: If61296ff4745e1699f3e216811c1383582627604
(cherry picked from commit aaa82f763471953fd9bad59e2d0ad3240e6f08ff)
1 file changed
tree: 5c35ec741be18b1a34036000668d180d1be12471
  1. client/
  2. daemon/
  3. sysdeps/
  4. .clang-format ⇨ ../.clang-format-4
  5. adb.cpp
  6. adb.h
  7. adb_auth.h
  8. adb_auth_host.cpp
  9. adb_client.cpp
  10. adb_client.h
  11. adb_io.cpp
  12. adb_io.h
  13. adb_io_test.cpp
  14. adb_listeners.cpp
  15. adb_listeners.h
  16. adb_listeners_test.cpp
  17. adb_mdns.h
  18. adb_trace.cpp
  19. adb_trace.h
  20. adb_unique_fd.h
  21. adb_utils.cpp
  22. adb_utils.h
  23. adb_utils_test.cpp
  24. adbd_auth.cpp
  25. Android.bp
  26. Android.mk
  27. bugreport.cpp
  28. bugreport.h
  29. bugreport_test.cpp
  30. commandline.cpp
  31. commandline.h
  32. console.cpp
  33. CPPLINT.cfg
  34. diagnose_usb.cpp
  35. diagnose_usb.h
  36. fdevent.cpp
  37. fdevent.h
  38. fdevent_test.cpp
  39. fdevent_test.h
  40. file_sync_client.cpp
  41. file_sync_service.cpp
  42. file_sync_service.h
  43. framebuffer_service.cpp
  44. jdwp_service.cpp
  45. line_printer.cpp
  46. line_printer.h
  47. MODULE_LICENSE_APACHE2
  48. NOTICE
  49. OVERVIEW.TXT
  50. protocol.txt
  51. remount_service.cpp
  52. remount_service.h
  53. security_log_tags.h
  54. services.cpp
  55. services.h
  56. SERVICES.TXT
  57. set_verity_enable_state_service.cpp
  58. shell_service.cpp
  59. shell_service.h
  60. shell_service_protocol.cpp
  61. shell_service_protocol_test.cpp
  62. shell_service_test.cpp
  63. socket.h
  64. socket_spec.cpp
  65. socket_spec.h
  66. socket_spec_test.cpp
  67. socket_test.cpp
  68. sockets.cpp
  69. sockets.dia
  70. SYNC.TXT
  71. sysdeps.h
  72. sysdeps_test.cpp
  73. sysdeps_unix.cpp
  74. sysdeps_win32.cpp
  75. sysdeps_win32_test.cpp
  76. test_adb.py
  77. test_device.py
  78. trace.sh
  79. transport.cpp
  80. transport.h
  81. transport_local.cpp
  82. transport_mdns.cpp
  83. transport_mdns_unsupported.cpp
  84. transport_test.cpp
  85. transport_usb.cpp
  86. usb.h