Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_packages_modules_adb / cc467f1e6b13da75de021e0d50ed0bfbfd9aa221
commitcc467f1e6b13da75de021e0d50ed0bfbfd9aa221[log] [tgz]
authorSpencer Low <CompareAndSwap@gmail.com>Sun Aug 02 18:13:54 2015 -0700
committerSpencer Low <CompareAndSwap@gmail.com>Sun Aug 02 18:13:54 2015 -0700
tree0b4ab9fbd4890f3860cb29e3174ce83281516a10
parentd0bdf9a27e8a3e17b1e666887ed2d85d94d606b5 [diff]
adb: win32: define UNICODE/_UNICODE, Unicode error messages, misc

Define the UNICODE and _UNICODE preprocessor symbols to make passing
char* to Ansi/Unicode-agnostic Windows and C Runtime APIs break the
build. The solution is to call wide Windows and C Runtime APIs and use
widen(utf8).c_str(). Most code was already calling wide APIs. Defining
these symbols makes a call to CreateEvent() (which previously mapped to
CreateEventA()) turn into a call to CreateEventW().

Make SystemErrorCodeToString() use Unicode.

Add various comments.

Change-Id: I9b212412348a29826718e897a486489e1f142d16
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
2 files changed
tree: 0b4ab9fbd4890f3860cb29e3174ce83281516a10
  1. client/
  2. daemon/
  3. .clang-format
  4. __init__.py
  5. adb.cpp
  6. adb.h
  7. adb_auth.cpp
  8. adb_auth.h
  9. adb_auth_client.cpp
  10. adb_auth_host.cpp
  11. adb_client.cpp
  12. adb_client.h
  13. adb_io.cpp
  14. adb_io.h
  15. adb_io_test.cpp
  16. adb_listeners.cpp
  17. adb_listeners.h
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. Android.mk
  23. commandline.cpp
  24. console.cpp
  25. CPPLINT.cfg
  26. device.py
  27. fdevent.cpp
  28. fdevent.h
  29. file_sync_client.cpp
  30. file_sync_service.cpp
  31. file_sync_service.h
  32. framebuffer_service.cpp
  33. get_my_path_darwin.cpp
  34. get_my_path_linux.cpp
  35. get_my_path_windows.cpp
  36. jdwp_service.cpp
  37. MODULE_LICENSE_APACHE2
  38. mutex_list.h
  39. NOTICE
  40. OVERVIEW.TXT
  41. protocol.txt
  42. qemu_tracing.cpp
  43. qemu_tracing.h
  44. remount_service.cpp
  45. remount_service.h
  46. services.cpp
  47. SERVICES.TXT
  48. set_verity_enable_state_service.cpp
  49. sockets.cpp
  50. sockets.dia
  51. SYNC.TXT
  52. sysdeps.h
  53. sysdeps_win32.cpp
  54. test_adb.py
  55. test_device.py
  56. test_track_devices.cpp
  57. transport.cpp
  58. transport.h
  59. transport_local.cpp
  60. transport_test.cpp
  61. transport_usb.cpp
  62. usb_linux.cpp
  63. usb_linux_client.cpp
  64. usb_osx.cpp
  65. usb_windows.cpp