Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_packages_modules_adb / 8dc9c86dd464007d6e5e0a4efb5945a05bf7cdc9
commit8dc9c86dd464007d6e5e0a4efb5945a05bf7cdc9[log] [tgz]
authorElliott Hughes <enh@google.com>Tue Aug 25 17:48:12 2015 -0700
committerElliott Hughes <enh@google.com>Tue Aug 25 17:48:12 2015 -0700
treea2d7b09e0de8adec4a12f67ee87c24c40b78e0fc
parentbfd8937cc4b7c6ebeab78696f4d91812bfff58ae [diff]
Possible Mac build fix.

The error was this:

  system/core/adb/usb_osx.cpp:203:74: error: values of type 'UInt32' should not
  be used as format arguments; add an explicit cast to 'unsigned int' instead
  [-Werror,-Wformat]
    snprintf(devpathBuf, sizeof(devpathBuf), "usb:%" PRIu32 "X", locationId);
                                                  ~~~            ^~~~~~~~~~
                                                                 (unsigned int)

Which seems to be because on LP64 UInt32 is "unsigned int" but on LP32 it was
"unsigned long". We don't have to care about LP32, so -- if we can -- we're
probably better off just using uint32_t instead of UInt32.

Change-Id: I576f76cf2016ee59caccbc317ef74b6e8d71d722
1 file changed
tree: a2d7b09e0de8adec4a12f67ee87c24c40b78e0fc
  1. client/
  2. daemon/
  3. .clang-format
  4. __init__.py
  5. adb.cpp
  6. adb.h
  7. adb_auth.cpp
  8. adb_auth.h
  9. adb_auth_client.cpp
  10. adb_auth_host.cpp
  11. adb_client.cpp
  12. adb_client.h
  13. adb_io.cpp
  14. adb_io.h
  15. adb_io_test.cpp
  16. adb_listeners.cpp
  17. adb_listeners.h
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. adbd.rc
  23. Android.mk
  24. commandline.cpp
  25. console.cpp
  26. CPPLINT.cfg
  27. device.py
  28. fdevent.cpp
  29. fdevent.h
  30. file_sync_client.cpp
  31. file_sync_service.cpp
  32. file_sync_service.h
  33. framebuffer_service.cpp
  34. get_my_path_darwin.cpp
  35. get_my_path_linux.cpp
  36. jdwp_service.cpp
  37. MODULE_LICENSE_APACHE2
  38. mutex_list.h
  39. NOTICE
  40. OVERVIEW.TXT
  41. protocol.txt
  42. qemu_tracing.cpp
  43. qemu_tracing.h
  44. remount_service.cpp
  45. remount_service.h
  46. services.cpp
  47. SERVICES.TXT
  48. set_verity_enable_state_service.cpp
  49. sockets.cpp
  50. sockets.dia
  51. SYNC.TXT
  52. sysdeps.h
  53. sysdeps_win32.cpp
  54. test_adb.py
  55. test_device.py
  56. test_track_devices.cpp
  57. transport.cpp
  58. transport.h
  59. transport_local.cpp
  60. transport_test.cpp
  61. transport_usb.cpp
  62. usb_linux.cpp
  63. usb_linux_client.cpp
  64. usb_osx.cpp
  65. usb_windows.cpp