Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_packages_modules_adb / 7d130c49c15c22992efe531e883108f4e9f5896b
commit7d130c49c15c22992efe531e883108f4e9f5896b[log] [tgz]
authorJosh Gao <jmgao@google.com>Mon Aug 06 18:38:47 2018 -0700
committerJosh Gao <jmgao@google.com>Mon Aug 06 18:50:10 2018 -0700
treee7b405c8085c8d014dddee2e0b94346bda646797
parent028e97e5edc98373a0b9c7216e3b116e005bd463 [diff]
adb: actually enable fdsan.

adb was using a custom unique_fd closer that didn't have an
implementation for fdsan, which meant that none of our FDs were
actually tracked. Guard this behind ifdefs so that we only use this
on Windows, and delete our implementation of Pipe in favor of the one
in libbase while we're at it. libbase's implementation always sets
O_CLOEXEC, so fix up the instance of Pipe that doesn't expect that.

Test: mma
Test: adb start-server
Test: debuggerd `pidof adbd`
Change-Id: Ic29d641a2f93fb42384b00c51775048c8bcbe152
3 files changed
tree: e7b405c8085c8d014dddee2e0b94346bda646797
  1. client/
  2. daemon/
  3. sysdeps/
  4. .clang-format ⇨ ../.clang-format-4
  5. adb.bash
  6. adb.cpp
  7. adb.h
  8. adb_auth.h
  9. adb_io.cpp
  10. adb_io.h
  11. adb_io_test.cpp
  12. adb_listeners.cpp
  13. adb_listeners.h
  14. adb_listeners_test.cpp
  15. adb_mdns.h
  16. adb_trace.cpp
  17. adb_trace.h
  18. adb_unique_fd.cpp
  19. adb_unique_fd.h
  20. adb_utils.cpp
  21. adb_utils.h
  22. adb_utils_test.cpp
  23. Android.bp
  24. Android.mk
  25. benchmark_device.py
  26. bugreport_test.cpp
  27. fdevent.cpp
  28. fdevent.h
  29. fdevent_test.cpp
  30. fdevent_test.h
  31. file_sync_protocol.h
  32. MODULE_LICENSE_APACHE2
  33. NOTICE
  34. OVERVIEW.TXT
  35. OWNERS
  36. protocol.txt
  37. security_log_tags.h
  38. services.cpp
  39. services.h
  40. SERVICES.TXT
  41. shell_protocol.h
  42. shell_service_protocol.cpp
  43. shell_service_protocol_test.cpp
  44. socket.h
  45. socket_spec.cpp
  46. socket_spec.h
  47. socket_spec_test.cpp
  48. socket_test.cpp
  49. sockets.cpp
  50. sockets.dia
  51. SYNC.TXT
  52. sysdeps.h
  53. sysdeps_test.cpp
  54. sysdeps_unix.cpp
  55. sysdeps_win32.cpp
  56. sysdeps_win32_test.cpp
  57. test_adb.py
  58. test_device.py
  59. trace.sh
  60. transport.cpp
  61. transport.h
  62. transport_benchmark.cpp
  63. transport_fd.cpp
  64. transport_local.cpp
  65. transport_test.cpp
  66. transport_usb.cpp
  67. types.h
  68. types_test.cpp
  69. usb.h