Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_packages_modules_adb / 67943d11b76d7693d817eb5898736c38abd7a44a
commit67943d11b76d7693d817eb5898736c38abd7a44a[log] [tgz]
authorElliott Hughes <enh@google.com>Wed Oct 07 14:55:10 2015 -0700
committerElliott Hughes <enh@google.com>Wed Oct 07 15:35:18 2015 -0700
tree47bb24231f7277f45afa1b3c98a773b0e982a94d
parentde01c94f969f6c59926bc7ace48c3ed0a707a670 [diff]
Fix adb -d/-e error reporting.

If -d/-e fail, get-serialno and friends will now report an error
and return a failure status code on exit.

Also fix the behavior of -d/-e with $ANDROID_SERIAL --- -d/-e
should override $ANDROID_SERIAL, not the other way round.

I'm deleting my own comment here about always returning "unknown"
for scripts. I can't find any evidence that there are scripts
relying on that, so I think my comment meant "I fear that there
are scripts doing so".

Bug: http://b/24403699
Change-Id: Ie13a751f1137abcfe0cc6c46a0630ba5e02db676
7 files changed
tree: 47bb24231f7277f45afa1b3c98a773b0e982a94d
  1. client/
  2. daemon/
  3. .clang-format
  4. adb.cpp
  5. adb.h
  6. adb_auth.cpp
  7. adb_auth.h
  8. adb_auth_client.cpp
  9. adb_auth_host.cpp
  10. adb_client.cpp
  11. adb_client.h
  12. adb_io.cpp
  13. adb_io.h
  14. adb_io_test.cpp
  15. adb_listeners.cpp
  16. adb_listeners.h
  17. adb_trace.cpp
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. Android.mk
  23. commandline.cpp
  24. console.cpp
  25. CPPLINT.cfg
  26. fdevent.cpp
  27. fdevent.h
  28. fdevent_test.cpp
  29. file_sync_client.cpp
  30. file_sync_service.cpp
  31. file_sync_service.h
  32. framebuffer_service.cpp
  33. get_my_path_darwin.cpp
  34. get_my_path_linux.cpp
  35. jdwp_service.cpp
  36. MODULE_LICENSE_APACHE2
  37. mutex_list.h
  38. NOTICE
  39. OVERVIEW.TXT
  40. protocol.txt
  41. remount_service.cpp
  42. remount_service.h
  43. services.cpp
  44. services.h
  45. SERVICES.TXT
  46. set_verity_enable_state_service.cpp
  47. shell_service.cpp
  48. shell_service.h
  49. shell_service_protocol.cpp
  50. shell_service_protocol_test.cpp
  51. shell_service_test.cpp
  52. socket.h
  53. socket_test.cpp
  54. sockets.cpp
  55. sockets.dia
  56. SYNC.TXT
  57. sysdeps.h
  58. sysdeps_win32.cpp
  59. sysdeps_win32_test.cpp
  60. test_adb.py
  61. test_track_devices.cpp
  62. transport.cpp
  63. transport.h
  64. transport_local.cpp
  65. transport_test.cpp
  66. transport_usb.cpp
  67. usb_linux.cpp
  68. usb_linux_client.cpp
  69. usb_osx.cpp
  70. usb_windows.cpp