Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_packages_modules_adb / 50740f56162807f9e88d36249e7d466d8ce5a282
commit50740f56162807f9e88d36249e7d466d8ce5a282[log] [tgz]
authorSpencer Low <CompareAndSwap@gmail.com>Tue Sep 08 17:13:04 2015 -0700
committerElliott Hughes <enh@google.com>Fri Sep 11 15:53:08 2015 -0700
tree6cb4130833d3bb7c40f5bfa38f2c707c66b7dc1a
parentf31b3b23eaa262e478f28868ce8fb1bb014f41df [diff]
adb: win32: make adb_getenv() case-insensitive

adb_getenv() should be case-insensitive just like the real getenv() on
Windows.

Added a unittest for adb_getenv(). In the process, made adb_test link
with -municode so that the environment block is Unicode.

Move wmain() from main.cpp to sysdeps_win32.cpp so that adb_test could
also use it.

Because wmain() moved, it wasn't as easy to do the runtime check to
verify that -municode was used, so do that check in _ensure_env_setup()
since adb_getenv() is called early in adb anyway.

Added a utility ToLower() which is good enough for env vars whose keys
are probably always ASCII to begin with.

Change-Id: I082f7fdee9dfe2c7f76b878528d2f7863df6d8d1
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
4 files changed
tree: 6cb4130833d3bb7c40f5bfa38f2c707c66b7dc1a
  1. client/
  2. daemon/
  3. .clang-format
  4. __init__.py
  5. adb.cpp
  6. adb.h
  7. adb_auth.cpp
  8. adb_auth.h
  9. adb_auth_client.cpp
  10. adb_auth_host.cpp
  11. adb_client.cpp
  12. adb_client.h
  13. adb_io.cpp
  14. adb_io.h
  15. adb_io_test.cpp
  16. adb_listeners.cpp
  17. adb_listeners.h
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. Android.mk
  23. commandline.cpp
  24. console.cpp
  25. CPPLINT.cfg
  26. device.py
  27. fdevent.cpp
  28. fdevent.h
  29. fdevent_test.cpp
  30. file_sync_client.cpp
  31. file_sync_service.cpp
  32. file_sync_service.h
  33. framebuffer_service.cpp
  34. get_my_path_darwin.cpp
  35. get_my_path_linux.cpp
  36. jdwp_service.cpp
  37. MODULE_LICENSE_APACHE2
  38. mutex_list.h
  39. NOTICE
  40. OVERVIEW.TXT
  41. protocol.txt
  42. remount_service.cpp
  43. remount_service.h
  44. services.cpp
  45. SERVICES.TXT
  46. set_verity_enable_state_service.cpp
  47. shell_service.cpp
  48. shell_service.h
  49. shell_service_protocol.cpp
  50. shell_service_protocol_test.cpp
  51. sockets.cpp
  52. sockets.dia
  53. SYNC.TXT
  54. sysdeps.h
  55. sysdeps_win32.cpp
  56. sysdeps_win32_test.cpp
  57. test_adb.py
  58. test_device.py
  59. test_track_devices.cpp
  60. transport.cpp
  61. transport.h
  62. transport_local.cpp
  63. transport_test.cpp
  64. transport_usb.cpp
  65. usb_linux.cpp
  66. usb_linux_client.cpp
  67. usb_osx.cpp
  68. usb_windows.cpp