| commit | 91da560bdcbe6d8581b980dddaa0317d0a586b7d | [log] [tgz] |
|---|---|---|
| author | Manoj Babulal <manoj.babulal@broadcom.com> | Thu Dec 27 02:43:19 2018 -0800 |
| committer | Manoj Babulal <manoj.babulal@broadcom.com> | Mon Jan 14 04:14:13 2019 +0000 |
| tree | ec885778c25eb96e04535b7bea7b47a7b57867bb | |
| parent | abeb161ec3c5bb523663fcd3a7de394e109ebc9f [diff] |
SMP: Fix invalid auth_req in LE Security Request handler Due to wrong pointer de-reference, auth_req value read in smp_proc_sec_req (LE Security Request packet handler) was invalid. Logcat trace shows invalid auth_req value: .. bt_smp : smp_proc_sec_req: auth_req=0xf9 .... .. bt_smp : smp_proc_sec_req: auth_req=0xe9 After the fix, auth_req value is correct: .. bt_smp : smp_proc_sec_req: auth_req=0x1 .... .. bt_smp : smp_proc_sec_req: auth_req=0x5 This data flow can be traced in code on this path: smp_data_received -> smp_sm_event -> smp_proc_sec_req Issue seen after following change: https://android-review.googlesource.com/c/platform/system/bt/+/492442 Issue was discovered during execution of PTS test cases GAP/SEC/AUT/BV-13-C and GAP/SEC/AUT/BV-14-C. Fixes: 122066779 Test: Verified logcat trace shows valid auth_req value prints from smp_proc_sec_req() function Change-Id: I072b4794fb56a05b7ac7f2f4ca606514d7524550
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/packages/modules/Bluetooth/system
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If packages/modules/Bluetooth/system is checked out under AOSP, then create symbolic links instead of downloading sources
cd packages/modules/Bluetooth/system mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd packages/modules/Bluetooth/system gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under packages/modules/Bluetooth/system/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"
Goto Behaviour tab, change clean command to "-t clean"