commit | 105d100ba774711c450917be567f2bb5822406d5 | [log] [tgz] |
---|---|---|
author | Sal Savage <salsavage@google.com> | Thu Apr 30 15:10:08 2020 -0700 |
committer | Sal Savage <salsavage@google.com> | Thu Apr 30 15:36:12 2020 -0700 |
tree | 569b2f67decd53e5ea29932b969115c6f5a04c49 | |
parent | 3ed1f736620e952dee229d315eb1ac4d87b6201a [diff] |
Allow Java-land to request current track metadata through JNI AVRCP Targets are not supposed to give image handles over with metadata until an AVRCP BIP client connects from a particular controller. Because this connection can happen any time and there's nothing forcing a target to send us a track changed notification to inform us of the new handle, the best thing we can do to work with all devices is to request it when we connect on BIP. Otherwise, we risk a race condition between the BIP connection and any amount of track changed notifications that might happen organically. Our JNI doesn't current support requesting current track metadata. This change adds/implements a get_current_track_metadata() method to the JNI. This, paired with a change in /packages/apps/Bluetooth/, fixes the above mentioned race condition and keeps us from missing out on possible cover art image handles. Bug: b/152655644 Test: Build, flash, test with AVRCP target cover art devices Change-Id: I9d1f28068b4fded61d5336da8d864fbd9ef34f98
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/packages/modules/Bluetooth/system
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If packages/modules/Bluetooth/system is checked out under AOSP, then create symbolic links instead of downloading sources
cd packages/modules/Bluetooth/system mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi
.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd packages/modules/Bluetooth/system gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under packages/modules/Bluetooth/system/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"
Goto Behaviour tab, change clean command to "-t clean"