Lint cleanup
Signed-off-by: Joey <joey@lineageos.org>
diff --git a/app/src/main/java/org/lineageos/backgrounds/adapters/WallsDiffCallback.java b/app/src/main/java/org/lineageos/backgrounds/adapters/WallsDiffCallback.java
index 32d3b34..37379ad 100644
--- a/app/src/main/java/org/lineageos/backgrounds/adapters/WallsDiffCallback.java
+++ b/app/src/main/java/org/lineageos/backgrounds/adapters/WallsDiffCallback.java
@@ -24,10 +24,10 @@
final class WallsDiffCallback extends DiffUtil.Callback {
@NonNull
- private List<WallpaperBundle> mOld;
+ private final List<WallpaperBundle> mOld;
@NonNull
- private List<WallpaperBundle> mNew;
+ private final List<WallpaperBundle> mNew;
WallsDiffCallback(@NonNull final List<WallpaperBundle> oldList,
@NonNull final List<WallpaperBundle> newList) {
diff --git a/app/src/main/java/org/lineageos/backgrounds/bundle/WallpaperBundle.java b/app/src/main/java/org/lineageos/backgrounds/bundle/WallpaperBundle.java
index df77983..5922d51 100644
--- a/app/src/main/java/org/lineageos/backgrounds/bundle/WallpaperBundle.java
+++ b/app/src/main/java/org/lineageos/backgrounds/bundle/WallpaperBundle.java
@@ -62,7 +62,7 @@
mType = type;
}
- public WallpaperBundle(@NonNull final Parcel parcel) {
+ private WallpaperBundle(@NonNull final Parcel parcel) {
final String parcelName = parcel.readString();
mName = parcelName == null ? "" : parcelName;
mContentDrawable = null;
diff --git a/app/src/main/java/org/lineageos/backgrounds/factory/BuiltInWallpaperFactory.java b/app/src/main/java/org/lineageos/backgrounds/factory/BuiltInWallpaperFactory.java
index a630574..7508d3c 100644
--- a/app/src/main/java/org/lineageos/backgrounds/factory/BuiltInWallpaperFactory.java
+++ b/app/src/main/java/org/lineageos/backgrounds/factory/BuiltInWallpaperFactory.java
@@ -26,7 +26,7 @@
import org.lineageos.backgrounds.bundle.WallpaperBundle;
import org.lineageos.backgrounds.bundle.WallpaperType;
-public class BuiltInWallpaperFactory {
+public final class BuiltInWallpaperFactory {
private BuiltInWallpaperFactory() {
}
diff --git a/app/src/main/java/org/lineageos/backgrounds/task/FetchDataImpl.java b/app/src/main/java/org/lineageos/backgrounds/task/FetchDataImpl.java
index 91dabc0..b5ff25d 100644
--- a/app/src/main/java/org/lineageos/backgrounds/task/FetchDataImpl.java
+++ b/app/src/main/java/org/lineageos/backgrounds/task/FetchDataImpl.java
@@ -19,7 +19,6 @@
import android.content.res.Resources;
import android.content.res.TypedArray;
import android.graphics.Color;
-import android.graphics.drawable.Drawable;
import android.util.TypedValue;
import androidx.annotation.NonNull;
diff --git a/app/src/main/java/org/lineageos/backgrounds/task/FetchDataTask.java b/app/src/main/java/org/lineageos/backgrounds/task/FetchDataTask.java
index df0e2ee..86a3ddd 100644
--- a/app/src/main/java/org/lineageos/backgrounds/task/FetchDataTask.java
+++ b/app/src/main/java/org/lineageos/backgrounds/task/FetchDataTask.java
@@ -25,7 +25,7 @@
import java.util.List;
-public class FetchDataTask extends AsyncTask<Void, Integer, List<WallpaperBundle>> implements
+public final class FetchDataTask extends AsyncTask<Void, Integer, List<WallpaperBundle>> implements
FetchDataImpl.Callback {
private final FetchDataTask.Callback mCallbacks;
diff --git a/app/src/main/java/org/lineageos/backgrounds/task/LoadDrawableFromUriImpl.java b/app/src/main/java/org/lineageos/backgrounds/task/LoadDrawableFromUriImpl.java
index 8b92136..271265d 100644
--- a/app/src/main/java/org/lineageos/backgrounds/task/LoadDrawableFromUriImpl.java
+++ b/app/src/main/java/org/lineageos/backgrounds/task/LoadDrawableFromUriImpl.java
@@ -30,7 +30,7 @@
import java.io.FileDescriptor;
import java.io.IOException;
-class LoadDrawableFromUriImpl {
+final class LoadDrawableFromUriImpl {
@NonNull
private final Callback mCallbacks;
diff --git a/app/src/main/java/org/lineageos/backgrounds/ui/ApplyActivity.java b/app/src/main/java/org/lineageos/backgrounds/ui/ApplyActivity.java
index 0e6ceae..9f147ad 100644
--- a/app/src/main/java/org/lineageos/backgrounds/ui/ApplyActivity.java
+++ b/app/src/main/java/org/lineageos/backgrounds/ui/ApplyActivity.java
@@ -41,7 +41,7 @@
import java.io.IOException;
-public class ApplyActivity extends AppCompatActivity {
+public final class ApplyActivity extends AppCompatActivity {
public static final String EXTRA_TRANSITION_NAME = "transition_shared_preview";
static final String EXTRA_WALLPAPER = "apply_extra_wallpaper_parcel";
@@ -178,7 +178,7 @@
.scaleX(0f)
.scaleY(0f)
.setDuration(75)
- .withEndAction(() -> finish())
+ .withEndAction(this::finish)
.start();
}
diff --git a/app/src/main/java/org/lineageos/backgrounds/ui/MainActivity.java b/app/src/main/java/org/lineageos/backgrounds/ui/MainActivity.java
index 6848766..a5b8de9 100644
--- a/app/src/main/java/org/lineageos/backgrounds/ui/MainActivity.java
+++ b/app/src/main/java/org/lineageos/backgrounds/ui/MainActivity.java
@@ -41,7 +41,7 @@
import java.util.List;
-public class MainActivity extends AppCompatActivity implements SelectionInterface {
+public final class MainActivity extends AppCompatActivity implements SelectionInterface {
private static final int PICK_IMAGE_FROM_EXT = 618;
private ProgressBar mLoadingProgressBar;
diff --git a/app/src/main/java/org/lineageos/backgrounds/util/ColorUtils.java b/app/src/main/java/org/lineageos/backgrounds/util/ColorUtils.java
index 2bbad5c..13b1e72 100644
--- a/app/src/main/java/org/lineageos/backgrounds/util/ColorUtils.java
+++ b/app/src/main/java/org/lineageos/backgrounds/util/ColorUtils.java
@@ -15,7 +15,6 @@
*/
package org.lineageos.backgrounds.util;
-import android.content.res.ColorStateList;
import android.graphics.Bitmap;
import android.graphics.Color;
import android.graphics.drawable.Drawable;
diff --git a/app/src/main/res/layout/activity_apply.xml b/app/src/main/res/layout/activity_apply.xml
index 5c33496..558d953 100644
--- a/app/src/main/res/layout/activity_apply.xml
+++ b/app/src/main/res/layout/activity_apply.xml
@@ -13,7 +13,7 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<merge xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
@@ -46,4 +46,4 @@
tools:textColor="@android:color/white"
tools:visibility="visible" />
-</FrameLayout>
+</merge>
diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml
index 5a06e04..9c7ba72 100644
--- a/app/src/main/res/layout/activity_main.xml
+++ b/app/src/main/res/layout/activity_main.xml
@@ -13,7 +13,7 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<merge xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="match_parent"
android:layout_height="match_parent">
@@ -35,11 +35,10 @@
android:textColor="?android:attr/textColorPrimary"
android:textSize="24sp" />
-
<androidx.recyclerview.widget.RecyclerView
android:id="@+id/main_recyclerview"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:paddingHorizontal="4dp"
android:visibility="gone" />
-</FrameLayout>
+</merge>