tree f208f4e68fdf504fd2039b07c719ca38a2234c61
parent e29d4363174949a7a4e46f670993d7ff43342c1c
author Eric Dumazet <eric.dumazet@gmail.com> 1258327824 +0000
committer David S. Miller <davem@davemloft.net> 1258371035 -0800

net: Fix the rollback test in dev_change_name()

net: Fix the rollback test in dev_change_name()

In dev_change_name() an err variable is used for storing the original
call_netdevice_notifiers() errno (negative) and testing for a rollback
error later, but the test for non-zero is wrong, because the err might
have positive value as well - from dev_alloc_name(). It means the
rollback for a netdevice with a number > 0 will never happen. (The err
test is reordered btw. to make it more readable.)

Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>