tree 669276e7cbc4f83d0c79d77ef2cff9dcc318fef4
parent e98d69ba464868a5d6b0b43730658810a29ff825
author Dan Carpenter <dan.carpenter@oracle.com> 1406820611 +0300
committer David S. Miller <davem@davemloft.net> 1406870094 -0700

ISDN: pcbit: off by one bugs in pcbit_set_msn()

1) We don't allocate enough space for the NUL terminator so we end up
   corrupting one character beyond the end of the buffer.

2) The "len - 1" should just be "len".  The code is trying to copy a
   word from a buffer up to a comma or the last word in the buffer.
   Say you have the buffer, "foo,bar,baz", then this code truncates the
   last letter off each word so you get "fo", "ba", and "ba".  You would
   hope this kind of bug would get noticed in testing...

   I'm not very familiar with this code and I can't test it, but I think
   we should copy the final character.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>