tree 63129e7d752fb018dc76aa42de136baa4a8a4232
parent b657c95c11088d77fc1bfc9c84d940f778bf9d12
author Joel Becker <joel.becker@oracle.com> 1226616552 -0800
committer Mark Fasheh <mfasheh@suse.com> 1231173412 -0800

ocfs2: Morph the haphazard OCFS2_IS_VALID_DINODE() checks.

Random places in the code would check a dinode bh to see if it was
valid.  Not only did they do different levels of validation, they
handled errors in different ways.

The previous commit unified inode block reads, validating all block
reads in the same place.  Thus, these haphazard checks are no longer
necessary.  Rather than eliminate them, however, we change them to
BUG_ON() checks.  This ensures the assumptions remain true.  All of the
code paths to these checks have been audited to ensure they come from a
validated inode read.

Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>