commit 9e314337cdc65b1fbf52060e9a6a4ddf2215c352
author Pablo Ceballos <pceballos@google.com> Tue Jan 12 13:49:19 2016 -0800
committer Pablo Ceballos <pceballos@google.com> Tue Feb 02 11:15:47 2016 -0800
tree fa3ac98f0e8fc8582224f4e0570ca0e592ec47ba
parent 23b4abe024ea88c45e0b94c80e1fb537a573b143

BQ: Conditionally compile validateConsistencyLocked

- Only enable it on userdebug and eng builds so that it won't slow
  down user builds.

Change-Id: I70933a23d54657fdf5cbc23873da4fbee84b9a26

libs/gui/BufferQueueProducer.cpp

diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp
index 22a2d79..3c06899 100644
--- a/libs/gui/BufferQueueProducer.cpp
+++ b/libs/gui/BufferQueueProducer.cpp
@@ -20,6 +20,12 @@
 #define ATRACE_TAG ATRACE_TAG_GRAPHICS
 //#define LOG_NDEBUG 0
 
+#if DEBUG_ONLY_CODE
+#define VALIDATE_CONSISTENCY() do { mCore->validateConsistencyLocked(); } while (0)
+#else
+#define VALIDATE_CONSISTENCY()
+#endif
+
 #define EGL_EGLEXT_PROTOTYPES
 
 #include <gui/BufferItem.h>
@@ -140,7 +146,7 @@
             return BAD_VALUE;
         }
         mCore->mMaxDequeuedBufferCount = maxDequeuedBuffers;
-        mCore->validateConsistencyLocked();
+        VALIDATE_CONSISTENCY();
         mCore->mDequeueCondition.broadcast();
         listener = mCore->mConsumerListener;
     } // Autolock scope
@@ -189,7 +195,7 @@
             return BAD_VALUE;
         }
         mCore->mAsyncMode = async;
-        mCore->validateConsistencyLocked();
+        VALIDATE_CONSISTENCY();
         mCore->mDequeueCondition.broadcast();
         listener = mCore->mConsumerListener;
     } // Autolock scope
@@ -495,7 +501,7 @@
                 return NO_INIT;
             }
 
-            mCore->validateConsistencyLocked();
+            VALIDATE_CONSISTENCY();
         } // Autolock scope
     }
 
@@ -566,7 +572,7 @@
     mCore->mFreeSlots.insert(slot);
     mCore->clearBufferSlotLocked(slot);
     mCore->mDequeueCondition.broadcast();
-    mCore->validateConsistencyLocked();
+    VALIDATE_CONSISTENCY();
 
     return NO_ERROR;
 }
@@ -616,7 +622,7 @@
     *outBuffer = mSlots[found].mGraphicBuffer;
     *outFence = mSlots[found].mFence;
     mCore->clearBufferSlotLocked(found);
-    mCore->validateConsistencyLocked();
+    VALIDATE_CONSISTENCY();
 
     return NO_ERROR;
 }
@@ -684,7 +690,7 @@
     mSlots[*outSlot].mRequestBufferCalled = true;
     mSlots[*outSlot].mAcquireCalled = false;
     mCore->mActiveBuffers.insert(found);
-    mCore->validateConsistencyLocked();
+    VALIDATE_CONSISTENCY();
 
     return returnFlags;
 }
@@ -861,7 +867,7 @@
         // Take a ticket for the callback functions
         callbackTicket = mNextCallbackTicket++;
 
-        mCore->validateConsistencyLocked();
+        VALIDATE_CONSISTENCY();
     } // Autolock scope
 
     // Don't send the GraphicBuffer through the callback, and don't send
@@ -948,7 +954,7 @@
 
     mSlots[slot].mFence = fence;
     mCore->mDequeueCondition.broadcast();
-    mCore->validateConsistencyLocked();
+    VALIDATE_CONSISTENCY();
 
     return NO_ERROR;
 }
@@ -1087,7 +1093,7 @@
     }
 
     mCore->mAllowAllocation = true;
-    mCore->validateConsistencyLocked();
+    VALIDATE_CONSISTENCY();
     return status;
 }
 
@@ -1252,7 +1258,7 @@
 
             mCore->mIsAllocating = false;
             mCore->mIsAllocatingCondition.broadcast();
-            mCore->validateConsistencyLocked();
+            VALIDATE_CONSISTENCY();
         } // Autolock scope
     }
 }
@@ -1316,7 +1322,8 @@
 
     mDequeueTimeout = timeout;
     mCore->mDequeueBufferCannotBlock = false;
-    mCore->validateConsistencyLocked();
+
+    VALIDATE_CONSISTENCY();
     return NO_ERROR;
 }