commit fe65288f74ee403d71b1f6f31947f1743af4557d
author Hongguang <hgchen@google.com> Wed Aug 18 17:42:42 2021 -0700
committer Hongguang <hgchen@google.com> Thu Aug 19 17:34:44 2021 -0700
tree 195471508780abb4f2ac54630fe2fa2096ead537
parent ecc3279efde22146aaa90b7f547cac77b9439c67

MediaEvent should be sent when shared memory info is passed.

Bug: 191825295
Test: atest android.media.tv.tuner.cts on both AIDL and HIDL HAL.
Test: sampletunertvinput
Change-Id: I4a6bcfd95bff7ecd0a12210f102d92a9b981eae2

media/jni/android_media_tv_Tuner.cpp

diff --git a/media/jni/android_media_tv_Tuner.cpp b/media/jni/android_media_tv_Tuner.cpp
index 5cbdc13..f1c72f8 100644
--- a/media/jni/android_media_tv_Tuner.cpp
+++ b/media/jni/android_media_tv_Tuner.cpp
@@ -633,7 +633,9 @@
                                  offset, nullptr, isSecureMemory, avDataId, mpuSequenceNumber,
                                  isPesPrivateData, audioDescriptor);
 
-    if (mediaEvent.avMemory.fds.size() > 0 || mediaEvent.avDataId != 0) {
+    uint64_t avSharedMemSize = mFilterClient->getAvSharedHandleInfo().size;
+    if (mediaEvent.avMemory.fds.size() > 0 || mediaEvent.avDataId != 0 ||
+        (dataLength > 0 && (dataLength + offset) < avSharedMemSize)) {
         sp<MediaEvent> mediaEventSp =
                 new MediaEvent(mFilterClient, dupFromAidl(mediaEvent.avMemory),
                                mediaEvent.avDataId, dataLength + offset, obj);
@@ -1756,15 +1758,16 @@
 }
 
 jobject JTuner::openDvr(DvrType type, jlong bufferSize) {
-    ALOGD("JTuner::openDvr");
+    ALOGV("JTuner::openDvr");
     if (mDemuxClient == nullptr) {
         return nullptr;
     }
+
     sp<DvrClient> dvrClient;
     sp<DvrClientCallbackImpl> callback = new DvrClientCallbackImpl();
     dvrClient = mDemuxClient->openDvr(type, (int) bufferSize, callback);
-
     if (dvrClient == nullptr) {
+        ALOGD("Failed to open Dvr");
         return nullptr;
     }
 
@@ -4060,7 +4063,7 @@
         ALOGD("Failed to set FD for dvr: dvr client not found");
         return;
     }
-    dvrClient->setFd((int)fd);
+    dvrClient->setFd(fd);
     ALOGV("set fd = %d", fd);
 }