commit 3b272227805c44756f0857d3c5aadabe8961b239
author Mady Mellor <madym@google.com> Mon May 23 19:59:57 2022 +0000
committer Mady Mellor <madym@google.com> Mon May 23 20:01:27 2022 +0000
tree 679ddf4cd0c36e5527534e753d3717a4e2eb5bde
parent d3f19bcb778a521996a5f1a89ad9d31f1561a52b

Fix a padding issue for bubble user education in RTL

The education view is placed on the right hand side of the screen
so the padding calculation to align the manage button in the education
view with the real manage button is slightly different.

Bug: 230579507
Test: manual - force education for bubbles to show, set RTL language,
               open up stack and look at manage button education
Change-Id: I282ed7eb2014d5d1a6d2b428572e495ce0d77c78

libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/ManageEducationView.kt

diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/ManageEducationView.kt b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/ManageEducationView.kt
index 2ecf388..e95e8e5 100644
--- a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/ManageEducationView.kt
+++ b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/ManageEducationView.kt
@@ -109,8 +109,15 @@
         visibility = View.VISIBLE
         expandedView.getManageButtonBoundsOnScreen(realManageButtonRect)
         val isRTL = mContext.resources.configuration.layoutDirection == LAYOUT_DIRECTION_RTL
-        manageView.setPadding(realManageButtonRect.left - expandedView.manageButtonMargin,
-                manageView.paddingTop, manageView.paddingRight, manageView.paddingBottom)
+        if (isRTL) {
+            val rightPadding = positioner.screenRect.right - realManageButtonRect.right -
+                    expandedView.manageButtonMargin
+            manageView.setPadding(manageView.paddingLeft, manageView.paddingTop,
+                    rightPadding, manageView.paddingBottom)
+        } else {
+            manageView.setPadding(realManageButtonRect.left - expandedView.manageButtonMargin,
+            manageView.paddingTop, manageView.paddingRight, manageView.paddingBottom)
+        }
         post {
             manageButton
                 .setOnClickListener {