commit 25d1ba5eb76902904348e3b6761580af920628b5
author Hai Zhang <zhanghai@google.com> Fri Mar 31 21:43:55 2023 +0000
committer Alexander Martinz <alex@amartinz.at> Mon Nov 18 08:35:01 2024 +0100
tree 0bbed9242a21188c3b21d95ac973ef70251f45ef
parent fe8444921275edd7ce523bc46b382aaab6df085a

Fix typo in PID check.

Fixes: 272021728
Test: presubmit
Change-Id: Id5f84a2985e5451c7ad92178715c21d441825afd

services/core/java/com/android/server/appop/AppOpsService.java

diff --git a/services/core/java/com/android/server/appop/AppOpsService.java b/services/core/java/com/android/server/appop/AppOpsService.java
index 65a704b..4eeb741 100644
--- a/services/core/java/com/android/server/appop/AppOpsService.java
+++ b/services/core/java/com/android/server/appop/AppOpsService.java
@@ -2318,19 +2318,20 @@
     }
 
     private void enforceGetAppOpsStatsPermissionIfNeeded(int uid, String packageName) {
-        final int callingUid = Binder.getCallingUid();
         // We get to access everything
-        if (callingUid == Process.myPid()) {
+        final int callingPid = Binder.getCallingPid();
+        if (callingPid == Process.myPid()) {
             return;
         }
         // Apps can access their own data
+        final int callingUid = Binder.getCallingUid();
         if (uid == callingUid && packageName != null
                 && checkPackage(uid, packageName) == MODE_ALLOWED) {
             return;
         }
         // Otherwise, you need a permission...
-        mContext.enforcePermission(android.Manifest.permission.GET_APP_OPS_STATS,
-                Binder.getCallingPid(), callingUid, null);
+        mContext.enforcePermission(android.Manifest.permission.GET_APP_OPS_STATS, callingPid,
+                callingUid, null);
     }
 
     /**