commit baae5fdc290d41e02adcf1ece76d98e74d1d0432
author Madhanraj Chelladurai <quic_mchellad@quicinc.com> Fri Sep 01 18:22:06 2023 +0200
committer Michael Bestas <mkbestas@lineageos.org> Wed Oct 25 03:17:32 2023 +0300
tree 2ecdc65d9d269c37a02d33be8d2ccd3abf97c84b
parent 09cfb265a2fa9f2294c131d893637adc96712e49

FP4: gps: Add NULL check before object access

Correct the NULL check code block and add NULL check before
object access.

Change-Id: Ic41b781b41fb4e21bbff8801d500a41a6d7219d0
CRs-fixed: 3084543

gps/android/utils/battery_listener.cpp

diff --git a/gps/android/utils/battery_listener.cpp b/gps/android/utils/battery_listener.cpp
index 9cbfabd..64ce2c8 100644
--- a/gps/android/utils/battery_listener.cpp
+++ b/gps/android/utils/battery_listener.cpp
@@ -184,16 +184,19 @@
 {
     {
         std::lock_guard<std::mutex> _l(mLock);
-        if (mHealth != NULL)
+        if (mHealth != NULL) {
             mHealth->unregisterCallback(this);
             auto r = mHealth->unlinkToDeath(this);
             if (!r.isOk() || r == false) {
                 LOC_LOGe("Transaction error in unregister to HealthHAL death: %s",
                         r.description().c_str());
             }
+        }
     }
     mDone = true;
-    mThread->join();
+    if (NULL !=  mThread) {
+        mThread->join();
+    }
 }
 
 void BatteryListenerImpl::serviceDied(uint64_t cookie __unused,
@@ -210,7 +213,9 @@
     }
     mHealth = NULL;
     mCond.notify_one();
-    mThread->join();
+    if (NULL !=  mThread) {
+        mThread->join();
+    }
     std::lock_guard<std::mutex> _l(mLock);
     init();
 }