Turn ndk link check warning into error

All instances of this have been removed from the downstream trees. The
APK->JNI_SHARED_LIBRARY and Java->Java checks remain as warnings.

Change-Id: I3eaee284500deee0f26a4f9cdd96497e99ec533e
diff --git a/core/binary.mk b/core/binary.mk
index 9d3ef9b..73b3bd9 100644
--- a/core/binary.mk
+++ b/core/binary.mk
@@ -1239,7 +1239,7 @@
 ifdef my_link_type_deps
 	$(hide) for f in $(PRIVATE_DEPS); do \
 	  grep -qE '^$(PRIVATE_ALLOWED_TYPES)$$' $$f || \
-	    $(call echo-warning,"$(PRIVATE_MAKEFILE): $(PRIVATE_MODULE) ($(PRIVATE_LINK_TYPE)) should not link to $$(basename $${f%_intermediates/link_type}) ($$(cat $$f))"); \
+	    ($(call echo-error,"$(PRIVATE_MAKEFILE): $(PRIVATE_MODULE) ($(PRIVATE_LINK_TYPE)) should not link to $$(basename $${f%_intermediates/link_type}) ($$(cat $$f))"); exit 1) \
 	done
 endif
 	$(hide) echo $(PRIVATE_LINK_TYPE) >$@