commit a2a9f9990fb18ad4323ade0e8893e1d6e49614b6
author Tianjie Xu <xunchang@google.com> Fri Jan 05 15:15:54 2018 -0800
committer Tianjie Xu <xunchang@google.com> Tue Jan 23 01:29:56 2018 +0000
tree cb08d5b2c736be29f8db4ca0ad67afdb83434212
parent 7e41fb46dbe7905daa34bb75c27b6508aed2c121

Don't check the stderr output from bsdiff/imgdiff

bsdiff/imgdiff returns non-zero values correctly in case of failures.
So we don't need to check the stderr anymore. This avoids some false
reports of the diff program.

Bug: 72335938
Bug: 71505046
Test: Check the exit value of bsdiff/imgdiff in code search,
      generate a package for angler.

Change-Id: I18f0c3882a40a5288d6aee715713a05270e0db2b

tools/releasetools/common.py

diff --git a/tools/releasetools/common.py b/tools/releasetools/common.py
index ebebd63..faadae9 100644
--- a/tools/releasetools/common.py
+++ b/tools/releasetools/common.py
@@ -1385,7 +1385,7 @@
           p.kill()
           th.join()
 
-      if err or p.returncode != 0:
+      if p.returncode != 0:
         print("WARNING: failure running %s:\n%s\n" % (
             diff_program, "".join(err)))
         self.patch = None