Gitiles
Code Review Sign In
review.shift-gmbh.com / SHIFTPHONES / android_build / 8b0776d1ca59b81b27e5d52a23fc52187cf9e422
commit8b0776d1ca59b81b27e5d52a23fc52187cf9e422[log] [tgz]
authorYi-Yo Chiang <yochiang@google.com>Thu Jun 30 17:33:29 2022 +0800
committerYi-Yo Chiang <yochiang@google.com>Thu Jun 30 17:44:33 2022 +0800
tree28608a6ca37825a951dd251e585cc01d4b058253
parentea00bc65af63d114b5e3a87a12987f3dae60dad9 [diff]
Fix init_boot.img build rule with TARGET_NO_KERNEL:=true

If TARGET_NO_KERNEL is true (device has prebuilt boot.img), then the
init_boot.img build arguments wouldn't be propagated correctly.
This is because INTERNAL_INIT_BOOT_IMAGE_ARGS is misplaced within a
`ifneq ($(strip $(TARGET_NO_KERNEL)),true)` conditional block.

Fix this by moving INTERNAL_INIT_BOOT_IMAGE_ARGS initialization into the
`ifeq ($(BUILDING_INIT_BOOT_IMAGE),true)` block, which is closer to its
first use.

Bug: 237630862
Test: m initbootimage
Change-Id: I6c0ee2c4b5d0be77a93311eba714e0ed555ffd25
1 file changed
tree: 28608a6ca37825a951dd251e585cc01d4b058253
  1. common/
  2. core/
  3. orchestrator/
  4. packaging/
  5. target/
  6. tests/
  7. tools/
  8. .gitignore
  9. banchanHelp.sh
  10. buildspec.mk.default
  11. Changes.md
  12. CleanSpec.mk
  13. Deprecation.md
  14. envsetup.sh
  15. finalize_branch_for_release.sh
  16. help.sh
  17. METADATA
  18. navbar.md
  19. OWNERS
  20. PREUPLOAD.cfg
  21. rbesetup.sh
  22. README.md
  23. tapasHelp.sh
  24. Usage.txt
README.md

Android Make Build System

This is the Makefile-based portion of the Android Build System.

For documentation on how to run a build, see Usage.txt

For a list of behavioral changes useful for Android.mk writers see Changes.md

For an outdated reference on Android.mk files, see build-system.html. Our Android.mk files look similar, but are entirely different from the Android.mk files used by the NDK build system. When searching for documentation elsewhere, ensure that it is for the platform build system -- most are not.

This Makefile-based system is in the process of being replaced with Soong, a new build system written in Go. During the transition, all of these makefiles are read by Kati, and generate a ninja file instead of being executed directly. That's combined with a ninja file read by Soong so that the build graph of the two systems can be combined and run as one.