commit f15848dce8907dbedbcc344ec77767da041a3ff5
author Nolen Johnson <johnsonnolen@gmail.com> Tue Apr 05 14:59:35 2022 -0400
committer Michael Bestas <mkbestas@lineageos.org> Mon Aug 29 23:07:51 2022 +0300
tree 591ce783a1471498ec984711566ea06e0a8d7df6
parent d62d93914221baab714cded38f8ea7064353e81c

volume_manager: Move bind/mount failure from ERROR to WARNING

* Prevents users from seeing this message on FBE devices:
  `failed to bind mount /mnt/staging/emulated/media/0 to /storage/emulated`

* FDE users already have the workaround in line 75.

Change-Id: I47d1aaf1a5a85a46fd52dc924a91b378cd800b2d

volume_manager/EmulatedVolume.cpp

diff --git a/volume_manager/EmulatedVolume.cpp b/volume_manager/EmulatedVolume.cpp
index 88eb7d9..a1a0756 100644
--- a/volume_manager/EmulatedVolume.cpp
+++ b/volume_manager/EmulatedVolume.cpp
@@ -77,7 +77,6 @@
         return -EIO;
     }
     if (BindMount(bindPath, getPath()) != OK) {
-        PLOG(ERROR) << getId() << " failed to bind mount " << bindPath << " on " << getPath();
         ForceUnmount(kStagingPath);
         return -EIO;
     }

volume_manager/Utils.cpp

diff --git a/volume_manager/Utils.cpp b/volume_manager/Utils.cpp
index b8cf4eb..1a0a940 100644
--- a/volume_manager/Utils.cpp
+++ b/volume_manager/Utils.cpp
@@ -187,7 +187,7 @@
 
 status_t BindMount(const std::string& source, const std::string& target) {
     if (::mount(source.c_str(), target.c_str(), "", MS_BIND, NULL)) {
-        PLOG(ERROR) << "Failed to bind mount " << source << " to " << target;
+        PLOG(WARNING) << "Failed to bind mount " << source << " to " << target;
         return -errno;
     }
     return OK;