commit 8be0f39fec7f26164fd0791ff6d15bde65fc849c
author Tao Bao <tbao@google.com> Thu May 04 00:29:31 2017 +0000
committer Tao Bao <tbao@google.com> Thu May 04 00:31:11 2017 +0000
tree fa4fca46de414eb53dadacaa629571762147654f
parent ec9706738f35a859f66fd0758b73381055804f63

Revert "Remove EXPAND/STRINGIFY macros."

This reverts commit ec9706738f35a859f66fd0758b73381055804f63.

Reason for revert: It's not a good idea to put RECOVERY_API_VERSION in
common.h, which might be included by device-specific codes (but with
RECOVERY_API_VERSION undefined).

Change-Id: I9feb9c64a5af3e9165164622a59b043aa28a8b8c

common.h

diff --git a/common.h b/common.h
index 87b8477..62fb132 100644
--- a/common.h
+++ b/common.h
@@ -22,8 +22,8 @@
 
 #include <string>
 
-static constexpr int kRecoveryApiVersion = RECOVERY_API_VERSION;  // Defined in Android.mk.
-static_assert(kRecoveryApiVersion >= 3, "Invalid recovery API version.");
+#define STRINGIFY(x) #x
+#define EXPAND(x) STRINGIFY(x)
 
 class RecoveryUI;
 

install.cpp

diff --git a/install.cpp b/install.cpp
index 2cc0660..689f4a0 100644
--- a/install.cpp
+++ b/install.cpp
@@ -287,7 +287,7 @@
 
   *cmd = {
     binary,
-    std::to_string(kRecoveryApiVersion),
+    EXPAND(RECOVERY_API_VERSION),  // defined in Android.mk
     std::to_string(status_fd),
     path,
   };

recovery.cpp

diff --git a/recovery.cpp b/recovery.cpp
index 6dd9858..944c240 100644
--- a/recovery.cpp
+++ b/recovery.cpp
@@ -1501,7 +1501,7 @@
     property_list(print_property, NULL);
     printf("\n");
 
-    ui->Print("Supported API: %d\n", kRecoveryApiVersion);
+    ui->Print("Supported API: %d\n", RECOVERY_API_VERSION);
 
     int status = INSTALL_SUCCESS;