commit daad67f72f1d26fdb759326e504d540eab1e1392
author Alex Light <allight@google.com> Mon Dec 16 13:01:46 2019 -0800
committer Treehugger Robot <treehugger-gerrit@google.com> Tue Dec 17 02:46:56 2019 +0000
tree 664a8f08858c2386550b9aa390ae9d21c1276cec
parent 0cc40277ffb5f59eac672d844723920ad5f12d85

Fix typo FieldNameAndSignature vs MethodNameAndSignature.

We incorrectly used a FieldNameAndSignature object in a logging
message instead of a MethodNameAndSignature object. This led to a
confusing error message since it would print an unrelated field
instead of the problematic method.

Test: ./test.py --host
Bug: 146229883
Bug: 145311370
Change-Id: I862d18bc23d1a3220dea8b2cc1a349a20bffb3c1

openjdkjvmti/ti_redefine.cc

diff --git a/openjdkjvmti/ti_redefine.cc b/openjdkjvmti/ti_redefine.cc
index 53bf4df..1e77be8 100644
--- a/openjdkjvmti/ti_redefine.cc
+++ b/openjdkjvmti/ti_redefine.cc
@@ -980,7 +980,7 @@
     RecordFailure(
         ERR(UNSUPPORTED_REDEFINITION_METHOD_DELETED),
         StringPrintf("Method %s missing!",
-                     FieldNameAndSignature(&old_dex_file, fail->GetIndex()).ToString().c_str()));
+                     MethodNameAndSignature(&old_dex_file, fail->GetIndex()).ToString().c_str()));
     return false;
   }
   return true;