commit bc258fafc4a83bba82a306aeb08a30fae7cb61fc
author Elliott Hughes <enh@google.com> Thu Oct 06 14:45:21 2011 -0700
committer Elliott Hughes <enh@google.com> Thu Oct 06 14:45:21 2011 -0700
tree b49f858e98e0747a0cdfeb1a78b39b8d70c338bd
parent 5f9298a3430998af855930dc5df3133f55e1516c

Fix IncompatibleClassChangeError.

Before, we'd hit the end of FindClass and blow up because we don't expect a
pending exception.

Change-Id: Ia3ca89d2460782275c5217c31ce3b057d12d4fa6

src/class_linker.cc

diff --git a/src/class_linker.cc b/src/class_linker.cc
index c7006df..7225764 100644
--- a/src/class_linker.cc
+++ b/src/class_linker.cc
@@ -871,8 +871,8 @@
     return NULL;
   }
   // Return the loaded class.  No exceptions should be pending.
-  CHECK(klass->IsResolved());
-  CHECK(!self->IsExceptionPending());
+  CHECK(klass->IsResolved()) << descriptor;
+  CHECK(!self->IsExceptionPending()) << descriptor << " " << PrettyTypeOf(self->GetException());
   return klass;
 }
 
@@ -1848,13 +1848,10 @@
       klass->GetVirtualMethodDuringLinking(i)->SetMethodIndex(i);
     }
     // Link interface method tables
-    LinkInterfaceMethods(klass);
+    return LinkInterfaceMethods(klass);
   } else {
-    // Link virtual method tables
-    LinkVirtualMethods(klass);
-
-    // Link interface method tables
-    LinkInterfaceMethods(klass);
+    // Link virtual and interface method tables
+    return LinkVirtualMethods(klass) && LinkInterfaceMethods(klass);
   }
   return true;
 }