commit 3ea4ec5629613013ad9b0d7a69abdb94491ac46f
author buzbee <buzbee@google.com> Mon Aug 22 17:37:19 2011 -0700
committer buzbee <buzbee@google.com> Tue Aug 23 16:21:20 2011 -0700
tree 43274b3154f0b2cf58fe1abbe21151652a6bf8fc
parent 5174fe6e4e931c423e910366ff22ce0838567940

Misc fixes, new compiler unit tests

Fixed disassembly logging, miscellaneous codegen bugs and added a
set of unit tests (most of which fail because array allocation isn't quite
there yet in the codegen).

Failing tests conditionally compiled out for now.

Change-Id: I39c148f9a7686fac21c844a7a7f5ec86d4e0e1c5

src/thread.h

diff --git a/src/thread.h b/src/thread.h
index 7204577..bb97d4e 100644
--- a/src/thread.h
+++ b/src/thread.h
@@ -26,6 +26,8 @@
 class Thread;
 class ThreadList;
 class Throwable;
+class Array;
+class Class;
 
 class Mutex {
  public:
@@ -166,7 +168,6 @@
 
   static const size_t kDefaultStackSize = 64 * KB;
 
-// TODO - needs to be redone properly, just hacked into place for now
   // Runtime support function pointers
   void* (*pMemcpy)(void*, const void*, size_t);
   float (*pI2f)(int);
@@ -194,22 +195,19 @@
   long long (*pLdivmod)(long long, long long);
   bool (*pArtUnlockObject)(struct Thread*, struct Object*);
   bool (*pArtCanPutArrayElementNoThrow)(const struct ClassObject*,
-        const struct ClassObject*);
-  int (*pArtInstanceofNonTrivialNoThrow)
-    (const struct ClassObject*, const struct ClassObject*);
-  int (*pArtInstanceofNonTrivial) (const struct ClassObject*,
-       const struct ClassObject*);
-  struct ArrayObject* (*pArtAllocArrayByClass)(struct ClassObject*,
-       size_t, int);
+                 const struct ClassObject*);
+  int (*pArtInstanceofNonTrivialNoThrow) (const struct ClassObject*,
+                const struct ClassObject*);
+  int (*pArtInstanceofNonTrivial) (const struct ClassObject*, const struct ClassObject*);
+  Array* (*pArtAllocArrayByClass)(Class*, size_t);
   struct Method* (*pArtFindInterfaceMethodInCache)(ClassObject*, uint32_t,
-        const struct Method*, struct DvmDex*);
+                           const struct Method*, struct DvmDex*);
   bool (*pArtUnlockObjectNoThrow)(struct Thread*, struct Object*);
   void (*pArtLockObjectNoThrow)(struct Thread*, struct Object*);
   struct Object* (*pArtAllocObjectNoThrow)(struct ClassObject*, int);
   void (*pArtThrowException)(struct Thread*, struct Object*);
   bool (*pArtHandleFillArrayDataNoThrow)(struct ArrayObject*, const uint16_t*);
 
-
   // Creates a new thread.
   static Thread* Create(const Runtime* runtime);
 
@@ -388,6 +386,7 @@
         exception_(NULL),
         suspend_count_(0),
         class_loader_override_(NULL) {
+    InitFunctionPointers();
   }
 
   ~Thread() {
@@ -395,6 +394,7 @@
   }
 
   void InitCpu();
+  void InitFunctionPointers();
 
   // Managed thread id.
   uint32_t id_;