commit 2e1c16d9a4695e4b5cab3ed3ec95f7a88e69c79f
author Sebastien Hertz <shertz@google.com> Fri Aug 28 11:57:49 2015 +0200
committer Sebastien Hertz <shertz@google.com> Mon Aug 31 16:36:05 2015 +0200
tree 82b8c3e9dcfccec6d42d23f1ad3429723142b86f
parent 9ee5d6cdc14ac94b64ea1961bf221bad48746929

JDWP: check object is assignable in ArrayReference.SetValues

If the object's type is not compatible with the array's type, we
return a TYPE_MISMATCH error.

Bug: 23602995
Change-Id: Ibd838dd301e40db4f08c74c9783707d1c87c67fd

runtime/debugger.cc

diff --git a/runtime/debugger.cc b/runtime/debugger.cc
index 0cbbb79..d9fbecc 100644
--- a/runtime/debugger.cc
+++ b/runtime/debugger.cc
@@ -1191,6 +1191,10 @@
       if (error != JDWP::ERR_NONE) {
         return error;
       }
+      // Check if the object's type is compatible with the array's type.
+      if (o != nullptr && !o->InstanceOf(oa->GetClass()->GetComponentType())) {
+        return JDWP::ERR_TYPE_MISMATCH;
+      }
       oa->Set<false>(offset + i, o);
     }
   }