commit 22869a9026a08b544eca4cefd67386d347e30d2c
author Elliott Hughes <enh@google.com> Tue Mar 27 14:08:24 2012 -0700
committer Elliott Hughes <enh@google.com> Tue Mar 27 14:08:24 2012 -0700
tree 814001ed308907e6562516c247658291cc805545
parent ab7b9dcbfc4264a0bc4889c3e463ff88a67f6a30

Warn if a thread attaches without a name and blow up if a thread detaches while running.

Also don't crash if a thread attaches without a name. Doing so is allowed, even
if it's not a good idea.

Change-Id: If5796af689e9221ce21f443023b0d793a8be15b0

src/thread.cc

diff --git a/src/thread.cc b/src/thread.cc
index dea554f..8bd7bc2 100644
--- a/src/thread.cc
+++ b/src/thread.cc
@@ -415,8 +415,10 @@
     self->CreatePeer(thread_name, as_daemon, thread_group);
   } else {
     // These aren't necessary, but they improve diagnostics for unit tests & command-line tools.
-    self->name_->assign(thread_name);
-    ::art::SetThreadName(thread_name);
+    if (thread_name != NULL) {
+      self->name_->assign(thread_name);
+      ::art::SetThreadName(thread_name);
+    }
   }
 
   self->GetJniEnv()->locals.AssertEmpty();